Date: Fri, 23 Apr 2004 02:23:41 +0200 From: Ronald Klop <ronald-freebsd6@klop.yi.org> To: Herve Quiroz <herve.quiroz@esil.univ-mrs.fr>, freebsd-java@freebsd.org Subject: Re: updating my port to bsd.java.mk options Message-ID: <opr6vvdrmsegu5x0@outgoing.local> In-Reply-To: <20040422191952.GA50032@arabica.esil.univ-mrs.fr> References: <opr6vb6clxegu5x0@outgoing.local> <20040422175758.GA30200@arabica.esil.univ-mrs.fr> <opr6vfqyhfegu5x0@outgoing.local> <20040422191952.GA50032@arabica.esil.univ-mrs.fr>
next in thread | previous in thread | raw e-mail | index | archive | help
--Boundary_(ID_zeAXgAnZxw/1OdG/5LvlBw)
Content-type: text/plain; format=flowed; charset=iso-8859-1
Content-transfer-encoding: 7BIT
On Thu, 22 Apr 2004 21:19:52 +0200, Herve Quiroz
<herve.quiroz@esil.univ-mrs.fr> wrote:
> On Thu, Apr 22, 2004 at 08:46:00PM +0200, Ronald Klop wrote:
>> >When nothing is set (neither JAVA_BUILD nor JAVA_RUN), bsd.java.mk
>> >assumes the folloing default values:
>> >
>> >JAVA_BUILD= jdk
>> >JAVA_RUN= jre
>>
>> Maybe this can be documented in bsd.java.mk. (Or is it already
>> documented
>> somewhere?)
>
> It's part of the just-in-time fixes we applied to bsd.java.mk so it's
> not yet documented. But as soon as the ports tree is unfrozen, I'll do
> that.
>
>> >So your patch is correct is this regard. You just need to remove the
>> >NEED_JAVAC statement. I tested it on my box and it seems to work. I
>> said
>> >"seems" because I have a build error. I've attached the log just in
>> >case. I haven't got enough time to debug it myself at the moment so if
>> >you know the problem, please tell me (I'll investigate myself in a few
>> >days otherwise).
>>
>> I see the same problem. It's happens when NEED_JAVAC is removed. I'll
>> investigate this later, because I have a basketball game to win in half
>> an
>> hour.
>
> Ok I'll check that as well.
When I look at bsd.java.mk I see that JAVAC is only defined if
NEED_JAVAC=yes.
I think this is the problem. JAVAH is always defined for example.
I attached a patch to bsd.java.mk which fixes my problem. But I don't know
if it is wanted for other ports.
And I attached a latest version of the patch to my port.
> BTW, have a good play!
We did win!
Cheers,
Ronald.
--
Amsterdam, The Netherlands
--Boundary_(ID_zeAXgAnZxw/1OdG/5LvlBw)
Content-type: application/octet-stream; name=bsd.java.mk.patch
Content-transfer-encoding: 8bit
Content-disposition: attachment; filename=bsd.java.mk.patch
--- bsd.java.mk.orig Fri Apr 23 02:08:06 2004
+++ bsd.java.mk Fri Apr 23 02:06:48 2004
@@ -528,6 +528,9 @@
APPLETVIEWER= ${JAVA_HOME}/bin/appletviewer
JAR= ${JAVA_HOME}/bin/jar
JAVA= ${JAVA_HOME}/bin/java
+.if !defined(JAVAC)
+JAVAC= ${JAVA_HOME}/bin/javac
+.endif
JAVADOC= ${JAVA_HOME}/bin/javadoc
JAVAH= ${JAVA_HOME}/bin/javah
JAVAP= ${JAVA_HOME}/bin/javap
--Boundary_(ID_zeAXgAnZxw/1OdG/5LvlBw)
Content-type: application/octet-stream; name=jmp.Makefile.patch
Content-transfer-encoding: 8bit
Content-disposition: attachment; filename=jmp.Makefile.patch
diff -ur /usr/ports/java/jmp/Makefile jmp/Makefile
--- /usr/ports/java/jmp/Makefile Mon Apr 5 18:54:38 2004
+++ jmp/Makefile Fri Apr 23 02:10:27 2004
@@ -35,8 +35,9 @@
USE_LIBTOOL_VER=13
USE_GMAKE= yes
-USE_JAVA= 1.2+
-NEED_JAVAC= yes
+USE_JAVA= yes
+JAVA_VERSION= 1.2+
+JAVA_OS= native
MAKE_FLAGS= JAVAC=${JAVAC} JAVAH=${JAVAH}
Only in jmp: work
--Boundary_(ID_zeAXgAnZxw/1OdG/5LvlBw)--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?opr6vvdrmsegu5x0>