Date: Thu, 18 Dec 2008 12:57:10 GMT From: "Andriy 'squirL' Tovstik" <andriy.tovstik@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/129733: incorrect GEOM status report from check_geom nagios plugin Message-ID: <200812181257.mBICvA07076160@www.freebsd.org> Resent-Message-ID: <200812181300.mBID0BM1076893@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 129733
>Category: ports
>Synopsis: incorrect GEOM status report from check_geom nagios plugin
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu Dec 18 13:00:11 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Andriy 'squirL' Tovstik
>Release: 7.0,6,2,6,3,6.4
>Organization:
redtram.com
>Environment:
>Description:
port /usr/ports/net-mgmt/nagios-geom/ has an error in GEOM status check. it returns OK status even if status of mirror is DEGRADED because sequence of logical operator is wrong
>How-To-Repeat:
# gmirror status
Name Status Components
mirror/gm1 DEGRADED ad4
# /usr/local/libexec/nagios/check_geom mirror gm1
OK mirror/gm1 DEGRADED { ad4 }|geom_mirror=1;;;0;
>Fix:
92c92
< if ( ( $class eq "mirror" || $class eq "raid3" ) && $status =~ /COMPLETE/ ) {
---
> if ($class eq "mirror" || $class eq "raid3" && $status =~ /COMPLETE/ ) {
96c96
< if ( ( $class eq "stripe" || $class eq "concat" || $class eq "shsec" ) && $status =~ /UP/) {
---
> if ($class eq "stripe" || $class eq "concat" || $class eq "shsec" && $status =~ /UP/) {
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812181257.mBICvA07076160>