Date: Tue, 7 May 2013 01:40:34 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Jimmy Olgeni <olgeni@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r317548 - head/lang/erlang Message-ID: <20130507014034.GB14600@FreeBSD.org> In-Reply-To: <201305062018.r46KIXbK048584@svn.freebsd.org> References: <201305062018.r46KIXbK048584@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 06, 2013 at 08:18:33PM +0000, Jimmy Olgeni wrote: > New Revision: 317548 > URL: http://svnweb.freebsd.org/changeset/ports/317548 > > Log: > Do not try to install empty DOCSDIR. > > @@ -200,8 +200,8 @@ post-install: > @${INSTALL_DATA} ${WRKSRC}/lib/dialyzer/doc/*.txt \ > ${PREFIX}/lib/${ERLANG_LIB}/lib/dialyzer-*/doc/ > > - @${MKDIR} ${DOCSDIR} > .for FILE in ${DOC_DISTFILES} > + @${MKDIR} ${DOCSDIR} > @${INSTALL_DATA} ${DISTDIR}/${DIST_SUBDIR}/$$(expr ${FILE} : '\([^:]*\)') ${DOCSDIR} > .endfor > .endif I don't quite understand this change. Why move mkdir inside the loop? How is can be empty when the whole thing is already inside .if ${PORT_OPTIONS:MDOCS}? The port itself could probably benefit from some cleaning and fixing of several style bugs. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130507014034.GB14600>