Date: Fri, 6 Sep 2013 13:36:36 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: David Chisnall <theraven@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r255297 - in head: include lib/libc/iconv lib/libiconv_modules Message-ID: <20130906103636.GF41229@kib.kiev.ua> In-Reply-To: <201309060946.r869kj8T064459@svn.freebsd.org> References: <201309060946.r869kj8T064459@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--wQFNOvpuONRGomCw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 06, 2013 at 09:46:45AM +0000, David Chisnall wrote: > --- head/lib/libiconv_modules/Makefile Fri Sep 6 09:08:40 2013 (r255296) > +++ head/lib/libiconv_modules/Makefile Fri Sep 6 09:46:44 2013 (r255297) > @@ -2,6 +2,9 @@ > =20 > .include <bsd.own.mk> > =20 > +CFLAGS+=3D -Dbool=3D_Bool > +.export CFLAGS > + > SUBDIR=3D BIG5 DECHanyu EUC EUCTW GBK2K HZ ISO2022 JOHAB MSKanji UES UTF= 1632 \ > UTF7 UTF8 VIQR ZW iconv_none iconv_std mapper_646 mapper_none \ > mapper_parallel mapper_serial mapper_std mapper_zone This is extremely rude. Such things are traditionally (and properly) done with Makefile.inc in our tree. Look at the very beginning of mk/bsd.init.mk. But the whole commit is hack. If you want to use C99 _Bool, use it directly instead of obfuscating the code through the build system. --wQFNOvpuONRGomCw Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (FreeBSD) iQIcBAEBAgAGBQJSKbA0AAoJEJDCuSvBvK1BbeIQAJZmJMD9vDtHqfoz/RphPw+/ JFWZxdfLTIps5go/+zGHOY75GMNW4ag0B+TX5gvP/+5lW5P/lzPzs9+ViEQUdunl bh+EFjUGiMUjcvmdvz8yYFjH8iH8zqfLlmhPIuarahsRjMxAp7UvQc9rLQEbBC6Y VYgeBsW9FHeFS0LLQg+5gqmaZU3Rlx3+4F+I2iSrHaWKa1U+LPKXndb7MayTz7KB jm7Af1Ztmux9zbetNALZEtOYsFBncKlG4v9tAWiN3MJjm0Z5sqqX1ekGeiVrhVgl 9dPgdUbWh1Emcd1UdU9aVzZj3E5scbMTS6lqo/e+d37/8y25QNr2XFnKwXLGoNBq nHaZjIU3z5tw8PwtRQ7OFkONiHlivGzbejxc7S1gBfcvNHKk90JtWnMm8PFZ+MHb KeTRlrogtFdVRs5C87byWoIozFDU+5Y/QdTsQKWeZiZazQqbTZWCEtChlN6vSz++ UV+hMsSer4rJfRk2VPl5O+/3CYbrjZFBnW1Enhvnfny9hBMrozPx9FooMTFj7Rre A+kEv6JnLziTNjr/lixSC+UXvU+OSbppdBH5qn9DmCwZWlk+WRZdsKVNk3jPnUgF ygs0uFMh/73JtcM6W7Hsy/xA4bYEzNl9G5VhEpEnixvBqdiPX/0KceQtx0Nvia/c Zf5iVLjpOxVX/y4Fkmlt =n7+f -----END PGP SIGNATURE----- --wQFNOvpuONRGomCw--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130906103636.GF41229>