Date: Wed, 30 Dec 2009 16:01:51 -0800 From: Doug Barton <dougb@FreeBSD.org> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r201290 - head/usr.bin/fetch Message-ID: <4B3BE9EF.60400@FreeBSD.org> In-Reply-To: <200912302301.nBUN1nE5075671@svn.freebsd.org> References: <200912302301.nBUN1nE5075671@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Ruslan Ermilov wrote: > Author: ru > Date: Wed Dec 30 23:01:49 2009 > New Revision: 201290 > URL: http://svn.freebsd.org/changeset/base/201290 > > Log: > Treat an empty argument as an error, instead of fetching the > contents of the root directory. I'm pretty sure that you just broke portmaster's package functionality with this change. I'm doing: fetch -q -o - ${sitepath} 2>/dev/null to get the list of what is available on the package sites. Is there a reason that you need to make this change? Doug > Modified: > head/usr.bin/fetch/fetch.c > > Modified: head/usr.bin/fetch/fetch.c > ============================================================================== > --- head/usr.bin/fetch/fetch.c Wed Dec 30 22:46:08 2009 (r201289) > +++ head/usr.bin/fetch/fetch.c Wed Dec 30 23:01:49 2009 (r201290) > @@ -340,6 +340,11 @@ fetch(char *URL, const char *path) > fetchDebug = 1; > > /* parse URL */ > + url = NULL; > + if (*URL == '\0') { > + warnx("empty URL"); > + goto failure; > + } > if ((url = fetchParseURL(URL)) == NULL) { > warnx("%s: parse error", URL); > goto failure; > -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B3BE9EF.60400>