Date: Fri, 2 Mar 2001 14:17:22 +0600 (NOVT) From: nnd@mail.nsk.ru To: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/wall ttymsg.c wall.1 wall.c Message-ID: <200103020817.f228HMq00592@wint.itfs.nsk.su> In-Reply-To: <200103010543.f215hD097964@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In article <200103010543.f215hD097964@freefall.freebsd.org> you wrote: > > Modified files: > usr.bin/wall ttymsg.c wall.1 wall.c > Log: > o Add support for wall -g. This will send a message to all members of > a given group. > o Minor code style cleanups while I'm here > > Reviewed by: bde, kris, markm, audit@ And there is still trivial error in the 'ttymsg.c' after all that reviews ;-) You've change (void) strcpy(device + sizeof(_PATH_DEV) - 1, line); to strlcat(device, line, sizeof(device)); wich leads to the device's names of the "/dev/ttyv1ttyp0" kind due to 'static char device[...' definition. N.Dudorov To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200103020817.f228HMq00592>