Date: Sun, 29 Aug 2010 10:10:40 -0400 From: jhell <jhell@DataIX.net> To: olli hauer <ohauer@gmx.de> Cc: FreeBSD Ports <ports@freebsd.org>, gordon@freebsd.org Subject: Re: devel/p4d patch Message-ID: <4C7A6A60.3090309@DataIX.net> In-Reply-To: <4C7A5E20.4060302@gmx.de> References: <4C7A4FD0.1050304@DataIX.net> <4C7A5E20.4060302@gmx.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On 08/29/2010 09:18, olli hauer wrote:
> On 2010-08-29 14:17, jhell wrote:
>> Hi Gordon,
>>
>> I just upgraded devel/p4d port and you might find this patch
>> interesting. This port would previously bail out trying to display the
>> pkg-message file that it can't find without a path.
>>
>> On a second note. Where it displays this message ``post-install'' does
>> not seem like the right place to display this message as it is not
>> really noticeable during that stage. But to solve this file not being
>> found I patched it up with the following.
>>
>> --- Makefile.orig 2010-08-29 08:08:25.801295898 -0400
>> +++ Makefile 2010-08-29 08:10:49.149776482 -0400
>> @@ -49,7 +49,7 @@
>> ${INSTALL_PROGRAM} ${_DISTDIR}/p4d ${PREFIX}/sbin/
>>
>> post-install:
>> - @${CAT} pkg-message
>> + @${CAT} ${PORTSDIR}/devel/${PORTNAME}/pkg-message
>> ${MKDIR} ${DESTDIR}${P4ROOT}
>> ${CHOWN} p4admin:p4admin ${DESTDIR}${P4ROOT}
>> ${CHMOD} 750 ${DESTDIR}${P4ROOT}
>>
>>
>
> Hi J,
>
> this will only work if you install via ports but not via package.
>
> Try '@${CAT} ${PKGMESSAGE}' instead, the port system will find
> the file and it will be displayed during (package) install.
>
> post-install is the right section, but I agree the message can be
> overlooked easily, this is one of the reason some pkg-messages
> start and end with a line of '=' signs and have some blanks
> between the '====..' line and the message self.
>
Hi Olli,
Thank you for the feedback. I knew there was something more to it!. Good
to know that is the right place for this. Maybe adding a @${ECHO} to the
bottom and top of that statement to echo a separation line would make it
more clear. Leaving it up to Gordon as I just wanted to inform him about
the error so it can be fixed.
Thank you again & Regards,
--
jhell,v
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C7A6A60.3090309>