Date: Fri, 4 Oct 2002 23:30:40 +0200 From: Emiel Kollof <coolvibe@hackerheaven.org> To: Peter Wemm <peter@wemm.org> Cc: Poul-Henning Kamp <phk@critter.freebsd.dk>, n0go013 <ttz@blahdeblah.demon.co.uk>, current <freebsd-current@FreeBSD.ORG> Subject: Re: [ GEOM tests ] disklabel warnings and vinum drives lost Message-ID: <20021004213040.GA12938@hackerheaven.org> In-Reply-To: <20021004211157.378592A896@canning.wemm.org> References: <35389.1033748850@critter.freebsd.dk> <20021004211157.378592A896@canning.wemm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Peter Wemm (peter@wemm.org) wrote: > vinum is so much unbelievable stuff in it. Consider this stuff: > > sys/dev/vinum/vinumio.c: > [Biiiiig ugly if/else fallthrough snipped] Ick... Which sick person wrote that? switch() and cpp macros usually do wonders in cases like these in terms of readability/maintainability at least. > It goes *way* downhill from there. :-( And I stay away from vinum just a little longer after having seen and verified this... [snip] > This crud has *got* to be taken out and shot, then reworked to do it > properly. Amen! (and no, I'm not volunteering. I don't mind cleaning up code, but there are limits to what crud I touch) Cheers, Emiel -- When the English language gets in my way, I walk over it. -- Billy Sunday To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021004213040.GA12938>