Date: Mon, 18 Oct 2021 12:28:25 +0200 From: Tobias Kortkamp <tobik@freebsd.org> To: Bernhard Froehlich <decke@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: f8daab173840 - main - devel/kf5-kio: Remove extra CPE_VENDOR and inherit from USES=kde instead Message-ID: <YW1MSUS6covY3Sq1@loki.kortkamp.xyz> In-Reply-To: <202110180834.19I8YDmZ018027@gitrepo.freebsd.org> References: <202110180834.19I8YDmZ018027@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--v/0W4Okg88BKFRLd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Oct 18, 2021 at 08:34:13AM +0000, Bernhard Froehlich wrote:
> -USES=3D cmake compiler:c++11-lib cpe desktop-file-utils \
> - gettext gnome kde:5 qt:5 ssl tar:xz
> -CPE_VENDOR=3D kde
> +USES=3D cmake compiler:c++11-lib desktop-file-utils \
> + gettext gnome kde:5 cpe qt:5 ssl tar:xz
Wouldn't it better to change USES=3Dcpe a little to set variables
later in _USES_POST? Then other USES can set their own defaults
for CPE_* and we don't create a USES ordering problem that contributors
have to be surprised by.
diff --git a/Mk/Uses/cpe.mk b/Mk/Uses/cpe.mk
index 410a05c6e437..d88aa06c17f8 100644
--- a/Mk/Uses/cpe.mk
+++ b/Mk/Uses/cpe.mk
@@ -18,6 +18,11 @@
=20
.if !defined(_INCLUDE_USES_CPE_MK)
_INCLUDE_USES_CPE_MK=3D yes
+_USES_POST+=3D cpe
+.endif
+
+.if defined(_POSTMKINCLUDED) && !defined(_INCLUDE_USES_CPE_POST_MK)
+_INCLUDE_USES_CPE_POST_MK=3D yes
=20
CPE_PART ?=3D a
CPE_PRODUCT ?=3D ${PORTNAME:tl}
--v/0W4Okg88BKFRLd
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAmFtTEdfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1
N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF
H2F1LQf+NMgzLZQcMQjtRVDNGY378sgxbEAnROnvc3jueIvyByFM07Eo0fmb/EfB
hs9gWmGXZouKkUNJmH020cmQ/Xqojhzs+QJnThB46zqHbrr/gfuyRdwiI6eLBIbD
qNlpmxn/5VZxfxfD2ElrV92UcoT0GlX99Vd8KKeUyrRDKXuvwOVEHoO9iS4x58fC
oqtJnEodLIvLcjb+Yo9jej2ma2igaFIBYCTWjF+TCED+pYA+qX3d4FOqSocvcpcr
YenxXJdZ1lCNa2arhhvfz7BE8svXGO+B1+G7L/59spIJnLSc7UYtrn1x8VK6RDBe
lEj2H0vbTzJzRZiUfyMzNvyy+xgk9Q==
=ZqiF
-----END PGP SIGNATURE-----
--v/0W4Okg88BKFRLd--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YW1MSUS6covY3Sq1>