Date: Sun, 25 Mar 2001 10:16:58 +0400 From: Alex Kapranoff <kapr@acm.org> To: Kris Kennaway <kris@obsecurity.org> Cc: ports@freebsd.org Subject: Re: Conditionalizing MACHINE_CPU checks Message-ID: <20010325101657.C1202@kapran.bitmcnit.bryansk.su> In-Reply-To: <20010324154609.A42192@xor.obsecurity.org>; from kris@obsecurity.org on Sat, Mar 24, 2001 at 03:46:09PM -0800 References: <20010319091353.A4146@kapran.bitmcnit.bryansk.su> <20010324154609.A42192@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 24, 2001 at 03:46:09PM -0800, Kris Kennaway wrote:
> On Mon, Mar 19, 2001 at 09:13:53AM +0300, Alex Kapranoff wrote:
> > Good day to all.
> >
> > Do I really need to wrap MACHINE_CPU tests (like ${MACHINE_CPU:Mmmx})
> > inside ${OSVERSION} >= 500018 tests?
>
> It's also in RELENG_4 now, so you should use check for
>
> ${OSVERSION} >= 500018 || ( ${OSVERSION} < 500000 && ${OSVERSION} >= 430000 )
How about defined(MACHINE_CPU) instead?
> > E.g. is it ok to do tests in this way:
> >
> > .if defined(WITH_MMX) || ${MACHINE_CPU:Mmmx}
> > SRCS+= mmx.c
> > .elif ${ARCH} == "i386"
> > @${ECHO_MSG} "You can define WITH_MMX to use MMX instructions"
> > .endif
>
> I'd prefer to keep it under an .if OSVERSION test, so it becomes
> easier to just chop out the .else section when we stop supporting
> systems older than ${OSVERSION} == 430000
Point taken.
--
Alex Kapranoff, Voice: +7(0832)791845
We've lived 2001 hours in the brand new millenium...
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010325101657.C1202>