Date: Sat, 26 Jul 2008 10:49:14 GMT From: Ed Schouten <ed@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 145959 for review Message-ID: <200807261049.m6QAnEIh067022@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=145959 Change 145959 by ed@ed_dull on 2008/07/26 10:48:18 I think we want to call finit() at the bottom. I don't want to know the strange things that could happen when the descriptor would be closed, while we're still creating the device node in make_dev(). Affected files ... .. //depot/projects/mpsafetty/sys/dev/pts/pts.c#5 edit Differences ... ==== //depot/projects/mpsafetty/sys/dev/pts/pts.c#5 (text+ko) ==== @@ -532,11 +532,11 @@ tp = tty_alloc(&pts_class, psc, NULL); - finit(fp, fflags, DTYPE_PTS, tp, &ptsdev_ops); - /* Expose the slave device as well */ tty_makedev(tp, td->td_ucred, "pts/%u", psc->pts_unit); + finit(fp, fflags, DTYPE_PTS, tp, &ptsdev_ops); + return (0); } @@ -559,10 +559,10 @@ tp = tty_alloc(&pts_class, psc, NULL); - finit(fp, fflags, DTYPE_PTS, tp, &ptsdev_ops); - /* Expose the slave device as well */ tty_makedev(tp, td->td_ucred, "%s", name); + + finit(fp, fflags, DTYPE_PTS, tp, &ptsdev_ops); } #endif /* PTS_EXTERNAL */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200807261049.m6QAnEIh067022>