Date: Sun, 20 Jun 2021 18:25:48 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 256736] [bsd.port.mk] [regression] [patch] _FLAVOR_RECURSIVE_SH passes flavor to child make Message-ID: <bug-256736-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256736 Bug ID: 256736 Summary: [bsd.port.mk] [regression] [patch] _FLAVOR_RECURSIVE_SH passes flavor to child make Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: otis@FreeBSD.org Reporter: ross@ross-williams.net Assignee: otis@FreeBSD.org Flags: maintainer-feedback?(otis@FreeBSD.org) Created attachment 225957 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D225957&action= =3Dedit Patch The change introduced in bug #256301 (review D30579), which prevents child = make processes from receiving an empty `FLAVOR` variable when `FLAVOR` should be unset has the side effect of allowing any `FLAVOR` already in the parent ma= ke process environment to propagate to the child. The attached patch unsets `FLAVOR` before starting the child make. Behavior before: ``` $ make FLAVOR=3Dzabbix54 ... =3D=3D=3D> zabbix54-agent-5.4.1 FLAVOR is defined (to zabbix54) while = this port does not have FLAVORS. *** Error code 1 Stop. make[1]: stopped in /usr/ports/net-mgmt/zabbix54-agent *** Error code 1 Stop. ``` Expected behavior after: ``` $ make FLAVOR=3Dzabbix54 ... =3D=3D=3D> Fetching all distfiles required by zabbix54-agent-5.4.1 for = building $ echo $? 0 ``` --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-256736-7788>