Date: Sun, 28 Oct 2001 03:21:51 -0600 (CST) From: Mike Silbersack <silby@silby.com> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: Greg Lehey <grog@FreeBSD.org>, <mjacob@feral.com>, Jonathan Lemon <jlemon@flugsvamp.com>, "Andrey A. Chernov" <ache@nagual.pp.ru>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: Causing known breakage (was: cvs commit: src/sys/kern kern_conf.c subr_disk.c) Message-ID: <20011028031839.U95596-100000@achilles.silby.com> In-Reply-To: <31874.1004258544@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 28 Oct 2001, Poul-Henning Kamp wrote: > >So why haven't you fixed it? > > Because it is not my task to fix all broken drivers. > > The message is "WARNING: driver mistake ..." for a very good reason. > > For instance, I can see the bogus code (mentioned earlier) in asr.c > but since I have no hardware I cannot test my hypothesis that the > entire driverinit function can be removed. Well, since this is the point of contention, could we just comment out the code in driverinit and send the maintainer an e-mail about cleaning it up? I think it's fair to possibly break asr for a little while if it removes the possibility that a GENERIC kernel will panic on everyone. As of now, this is the only error I'm seeing, and PHK's panic policy for these types of errors sounds like it will be productive. So, let's blame/patch asr and move on. Mike "Silby" Silbersack To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011028031839.U95596-100000>