Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 1 Jun 2003 14:18:16 -0700
From:      "David O'Brien" <obrien@FreeBSD.org>
To:        Dag-Erling Smorgrav <des@ofug.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/share/mk bsd.sys.mk
Message-ID:  <20030601211816.GE79746@dragon.nuxi.com>
In-Reply-To: <xzp4r39a4w4.fsf@flood.ping.uio.no>
References:  <200306011831.h51IVQxD054651@repoman.freebsd.org> <xzp4r39a4w4.fsf@flood.ping.uio.no>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jun 01, 2003 at 11:01:47PM +0200, Dag-Erling Smorgrav wrote:
> "David E. O'Brien" <obrien@FreeBSD.org> writes:
> >   Modified files:
> >     share/mk             bsd.sys.mk 
> >   Log:
> >   Compile our code as C99 by default.
> 
> Please back this out immediately.  You can't possibly have tested it;
> it breaks the build quite badly.

Show me the failure.


> I'd also like you to back out the previous commit (1.19), which made
> CSTD pretty much useless.

Take it to the TRB.  It was useless before.  One cannot even set
CSTD=gnu89, which should be a NOP.  The same failure occurs for *any*
setting of CSTD because you were too agressive with -pedantic.  Rev 1.19
returns behavior back to the behavior of the past year.


# fgrep '$FreeBSD' /usr/share/mk/bsd.sys.mk 
# $FreeBSD: src/share/mk/bsd.sys.mk,v 1.17 2003/05/05 21:14:36 des Exp $

# cd /usr/src/sbin/adjkerntz/
# CSTD=gnu89 make
cc -O -pipe -march=athlon-xp   -std=gnu89 -pedantic -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized  -c /usr/src/sbin/adjkerntz/adjkerntz.c
cc1: warnings being treated as errors
In file included from /usr/src/sbin/adjkerntz/adjkerntz.c:52:
/usr/include/sys/time.h: In function `timespec2bintime':
/usr/include/sys/time.h:125: warning: ISO C89 forbids long long integer constants
/usr/include/sys/time.h: In function `timeval2bintime':
/usr/include/sys/time.h:142: warning: ISO C89 forbids long long integer constants
/usr/src/sbin/adjkerntz/adjkerntz.c: In function `main':
/usr/src/sbin/adjkerntz/adjkerntz.c:131: warning: ISO C does not support the `%m' printf format
/usr/src/sbin/adjkerntz/adjkerntz.c:155: warning: ISO C does not support the `%m' printf format
/usr/src/sbin/adjkerntz/adjkerntz.c:163: warning: ISO C does not support the `%m' printf format
/usr/src/sbin/adjkerntz/adjkerntz.c:291: warning: ISO C does not support the `%m' printf format
/usr/src/sbin/adjkerntz/adjkerntz.c:298: warning: ISO C does not support the `%m' printf format
/usr/src/sbin/adjkerntz/adjkerntz.c:316: warning: ISO C does not support the `%m' printf format
/usr/src/sbin/adjkerntz/adjkerntz.c:323: warning: ISO C does not support the `%m' printf format
/usr/src/sbin/adjkerntz/adjkerntz.c:338: warning: ISO C does not support the `%m' printf format
/usr/src/sbin/adjkerntz/adjkerntz.c:347: warning: ISO C does not support the `%m' printf format
/usr/src/sbin/adjkerntz/adjkerntz.c:358: warning: ISO C does not support the `%m' printf format
*** Error code 1

Stop in /usr/src/sbin/adjkerntz.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030601211816.GE79746>