Date: Sun, 14 Jun 2020 09:33:36 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 204521] [new driver] [request] Port rtsx from OpenBSD to FreeBSD Message-ID: <bug-204521-227-Jglj4CYpw6@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-204521-227@https.bugs.freebsd.org/bugzilla/> References: <bug-204521-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D204521 gnikl@justmail.de changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gnikl@justmail.de --- Comment #217 from gnikl@justmail.de --- (In reply to commit-hook from comment #202) Build fails on 11.3. With the following patch the build succeeds: --cut-- --- rtsx.c~ 2020-06-11 16:47:01.000000000 +0200 +++ rtsx.c 2020-06-14 10:51:27.873097000 +0200 @@ -37,10 +37,12 @@ #include <sys/cdefs.h> __FBSDID("$FreeBSD$"); +#include <sys/types.h> #include <sys/param.h> +#include <sys/systm.h> +#include <sys/kernel.h> #include <sys/module.h> #include <sys/errno.h> -#include <sys/kernel.h> #include <sys/bus.h> #include <sys/endian.h> #include <machine/bus.h> --cut-- Note: The missing piece is "#include <sys/systm.h>". The other includes and= the reordering are gleaned from other kernel sources referencing eg. bootverbos= e. I have no idea if there is a preferred include order. Now the more interesting part: the driver works successfully with this devi= ce in a Fujitsu H730 laptop: rtsx0@pci0:4:0:0: class=3D0xff0000 card=3D0x187f10cf chip=3D0x522710e= c rev=3D0x01 hdr=3D0x00 vendor =3D 'Realtek Semiconductor Co., Ltd.' device =3D 'RTS5227 PCI Express Card Reader' The card status is detected properly, the inversion switch is not required. Reading from a msdosfs formatted 2GB card worked fine. Writing and suspend/resume was not tested yet. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-204521-227-Jglj4CYpw6>