Date: Sun, 29 Mar 2020 19:15:54 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: "Greg 'groggy' Lehey" <grog@FreeBSD.org> Cc: rgrimes@FreeBSD.org, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r359419 - head/usr.bin/ncal Message-ID: <202003300215.02U2Fsad053932@gndrsh.dnsmgr.net> In-Reply-To: <20200330015536.GH87815@eureka.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-- Start of PGP signed section. > On Sunday, 29 March 2020 at 18:29:40 -0700, Rodney W. Grimes wrote: > >> On Sunday, 29 March 2020 at 4:03:09 -0700, Rodney W. Grimes wrote: > >>>> Author: grog > >>>> Date: Sun Mar 29 04:18:27 2020 > >>>> New Revision: 359419 > >>>> URL: https://svnweb.freebsd.org/changeset/base/359419 > >>>> > >>>> Log: > >>>> Remove spurious transition from Julian to Gregorian for country > >>>> "Latin". > >>>> > >>>> Arguably the entire -p option should be removed. It shows only a few > >>>> countries, and it doesn't have any relationship with the rest of the > >>>> program. > >>> > >>> This commit message and the diff below do not seem to match very well. > >>> Is this actually what you intended to commit? > >> > >> The material difference, yes. Do you have an issue with that? > > > > No, just that it seemed that an error may of happened, > > but having you confirm this infact was the inteded change > > I am quiet fine with it. > > Thanks. > > Do you have any thoughts on removing the -p option? It just prints a table right? Why does it need removed? The Latin one had a bogus year, and the table is sparse, but probably contains valid data for 90+% of the user base. Doesnt the data still have to be in the program to properly print calendars before the switch date? > >> It seems that some trailing blanks in unrelated text were removed as > >> well. diff doesn't show these by default, so they crept through. I > >> know it's bad style to mix style commits with functional commits, but > >> ultimately they had to go too. > > > > Diff by default does show white space change, > > one has to invoke it with -b or -w or one of the --ignore space > > change options to cause it to not show them. > > Right. Egg on my face, and you can be sure I'll run diff with the > correct options next time. > > Greg > -- > Sent from my desktop computer. > Finger grog@FreeBSD.org for PGP public key. > See complete headers for address and phone numbers. > This message is digitally signed. If your Microsoft mail program > reports problems, please read http://lemis.com/broken-MUA -- End of PGP section, PGP failed! -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202003300215.02U2Fsad053932>