Date: Tue, 30 Apr 2019 08:46:05 -0600 From: Warner Losh <imp@bsdimp.com> To: Mark Johnston <markj@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r346932 - head/sys/ufs/ufs Message-ID: <CANCZdfrK2rye6T6XwR1f=XiudK8PwvnhiJgaBPBxLGqoCdFEJA@mail.gmail.com> In-Reply-To: <20190430142641.GA34567@raichu> References: <201904292205.x3TM5Q7Z058461@repo.freebsd.org> <20190430060849.GB97846@FreeBSD.org> <20190430142641.GA34567@raichu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Apr 30, 2019 at 8:27 AM Mark Johnston <markj@freebsd.org> wrote: > On Tue, Apr 30, 2019 at 06:08:49AM +0000, Alexey Dokuchaev wrote: > > On Mon, Apr 29, 2019 at 10:05:26PM +0000, Mark Johnston wrote: > > > New Revision: 346932 > > > URL: https://svnweb.freebsd.org/changeset/base/346932 > > > > > > Log: > > > Optimize lseek(SEEK_DATA) on UFS. > > > > > > This version fixes the problems identified in r345244. > > > > > > Reviewed by: kib > > > @@ -56,6 +56,9 @@ __FBSDID("$FreeBSD$"); > > > #include <ufs/ufs/ufsmount.h> > > > #include <ufs/ufs/ufs_extern.h> > > > > > > +static ufs_lbn_t lbn_count(struct ufsmount *, int); > > > +static int readindir(struct vnode *, ufs_lbn_t, ufs2_daddr_t, struct > buf **); > > > > Is the prototype for static readindir() really needed here? > > Yes, when using a K&R definition. > > > > +static int > > > +readindir(vp, lbn, daddr, bpp) > > > + struct vnode *vp; > > > + ufs_lbn_t lbn; > > > + ufs2_daddr_t daddr; > > > + struct buf **bpp; > > > > Don't we prefer ASNI declarations over K&R these days? > > Yes, I was just staying consistent with the rest of the file. For new code, we do prefer ANSI prototypes and function definitions. But for ufs and friends, we're still using K&R for a variety of reasons. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrK2rye6T6XwR1f=XiudK8PwvnhiJgaBPBxLGqoCdFEJA>