Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 20 Feb 2007 11:24:02 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        Kostik Belousov <kostikbel@gmail.com>
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/i386/i386 db_trace.c
Message-ID:  <200702201124.03426.jhb@freebsd.org>
In-Reply-To: <20070220144012.GX39168@deviant.kiev.zoral.com.ua>
References:  <200702191057.l1JAvmZW059331@repoman.freebsd.org> <200702191849.54339.jhb@freebsd.org> <20070220144012.GX39168@deviant.kiev.zoral.com.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 20 February 2007 09:40, Kostik Belousov wrote:
> On Mon, Feb 19, 2007 at 06:49:53PM -0500, John Baldwin wrote:
> > On Monday 19 February 2007 05:57, Konstantin Belousov wrote:
> > > kib         2007-02-19 10:57:48 UTC
> > > 
> > >   FreeBSD src repository
> > > 
> > >   Modified files:
> > >     sys/i386/i386        db_trace.c 
> > >   Log:
> > >   Unbreak ddb stepping over special frames after the following commit:
> > 
> > amd64 might need the same fix, and kgdb needs to be updated for both as
> > well if it hasn't been already.
> I doubt it. Register calling conventions for amd64 made the same change 
> for this architecture to look like
> 	movq	%rsp, %rdi
> thus not modifying stack frame layout. Could someone with amd64 current box
> confirm/deny this ?

Ah, ok, had wondered about that.

> Kgdb is more involved. I think that some compatibility stuff needed there,
> to be able to step over both old and new kind of frames.

Yes, it will have to use the nearest __FreeBSD_version by checking the
osreldate variable from the core dump.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200702201124.03426.jhb>