Date: Sat, 7 Nov 2015 17:29:14 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Joerg Sonnenberger <joerg@britannica.bec.de> Cc: svn-src-all@freebsd.org Subject: Re: svn commit: r290499 - head/usr.bin/localedef Message-ID: <20151107162913.GL31432@ivaldir.etoilebsd.net> In-Reply-To: <20151107162617.GA21271@britannica.bec.de> References: <201511071622.tA7GMTDN099727@repo.freebsd.org> <20151107162617.GA21271@britannica.bec.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--I4VOKWutKNZEOIPu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 07, 2015 at 05:26:17PM +0100, Joerg Sonnenberger wrote: > On Sat, Nov 07, 2015 at 04:22:29PM +0000, Baptiste Daroussin wrote: > > Author: bapt > > Date: Sat Nov 7 16:22:29 2015 > > New Revision: 290499 > > URL: https://svnweb.freebsd.org/changeset/base/290499 > >=20 > > Log: > > Workaround an issue on i386 to unbreak the build until the real issue= is tracked > > down > >=20 > > Modified: > > head/usr.bin/localedef/collate.c > >=20 > > Modified: head/usr.bin/localedef/collate.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/usr.bin/localedef/collate.c Sat Nov 7 15:03:45 2015 (r290498) > > +++ head/usr.bin/localedef/collate.c Sat Nov 7 16:22:29 2015 (r290499) > > @@ -1255,7 +1255,8 @@ dump_collate(void) > > * Large (> UCHAR_MAX) character priorities > > */ > > RB_NUMNODES(collchar_t, collchars, &collchars, n); > > - large =3D calloc(sizeof (collate_large_t) * n, 1); > > + large =3D malloc(sizeof (collate_large_t) * n); > > + memset(large, 0, sizeof (collate_large_t) * n); > > if (large =3D=3D NULL) { > > fprintf(stderr, "out of memory"); > > return; >=20 > Why was this not calloc(sizeof(), n) in first place?! I tried not to diverge too much from upstream (Illumos here), that is the reason. but the same issue happens with calloc(sizeof(), n) Issue being: <jemalloc>: jemalloc_arena.c:353: Failed assertion: "p[i] =3D= =3D 0" Best regards, Bapt --I4VOKWutKNZEOIPu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlY+JtkACgkQ8kTtMUmk6ExymwCeLGPWn8G1YGlhgOYYpaxke4Ud rBsAoLkCMljFgQJ1HGLOtGlcm6yImSDH =sLgb -----END PGP SIGNATURE----- --I4VOKWutKNZEOIPu--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151107162913.GL31432>