Date: Thu, 9 Jun 2005 16:25:15 -0700 From: John Baldwin <john@baldwin.cx> To: Stephan Uphoff <ups@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_switch.c sched_4bsd.c Message-ID: <692e14e0d72d5737f1c12f3c8def892d@baldwin.cx> In-Reply-To: <200506091943.j59Jh8H3058277@repoman.freebsd.org> References: <200506091943.j59Jh8H3058277@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jun 9, 2005, at 12:43 PM, Stephan Uphoff wrote: > ups 2005-06-09 19:43:08 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_switch.c sched_4bsd.c > Log: > Lots of whitespace cleanup. > Fix for broken if condition. > > Submitted by: nate@ What was broken about the if test? The intention was that when FULL_PREEMPTION was off, we only preempt if the destination thread is an ithread or if the current thread is an idle priority thread. I think you've changed it so that we never preempt if the current thread is an idle thread now, which is very bad. I took out explicit calls to mi_switch() in the page zeroing thread in reliance on the behavior that we always preempt an idle priority thread. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?692e14e0d72d5737f1c12f3c8def892d>