Date: Wed, 19 Jan 2005 20:41:56 +0300 From: Gleb Smirnoff <glebius@freebsd.org> To: Brooks Davis <brooks@one-eyed-alien.net> Cc: net@freebsd.org Subject: Re: [TEST/REVIEW] ng_ipfw: node to glue together ipfw(4) andnetgraph(4) Message-ID: <20050119174156.GA10573@cell.sick.ru> In-Reply-To: <20050119165751.GA19365@odin.ac.hmc.edu> References: <20050117200610.GA90866@cell.sick.ru> <20050118183558.GA15150@odin.ac.hmc.edu> <41ED8D63.8090205@elischer.org> <20050119084526.GA5119@cell.sick.ru> <41EE2933.4090404@elischer.org> <20050119093608.GA5712@cell.sick.ru> <41EE3361.8D27FF5B@freebsd.org> <20050119123426.GA7825@cell.sick.ru> <20050119165751.GA19365@odin.ac.hmc.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 19, 2005 at 08:57:51AM -0800, Brooks Davis wrote: B> Off the top of my head, I don't like the idea. What are the savings in B> doing so? Is there a guarantee that you won't need more then one at B> once? Well, I've spent enough braincycles arguing with myself, so I ask you to decide "to merge or not to merge" between yourself, and them I'll accept any decision. P.S. Pls note, that I've added 'if (DIVERT_LOADED)', and were asked for a backout. This was done to avoid tag lookup in a case, when tag can not be present. I've intentionally didn't add 'if (NG_IPFW_LOADED)' here. However, I don't agree with this... -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050119174156.GA10573>