Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 8 Oct 2014 23:04:03 -0700
From:      Garrett Cooper <yaneurabeya@gmail.com>
To:        Alexander Motin <mav@FreeBSD.org>
Cc:        "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>
Subject:   Re: svn commit: r272805 - head/sys/cam
Message-ID:  <3EB30773-FEC7-4DF9-95A1-E5963FB22112@gmail.com>
In-Reply-To: <201410090553.s995rxHK066788@svn.freebsd.org>
References:  <201410090553.s995rxHK066788@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Also...

> On Oct 8, 2014, at 22:53, Alexander Motin <mav@FreeBSD.org> wrote:
>=20
> Author: mav
> Date: Thu Oct  9 05:53:58 2014
> New Revision: 272805
> URL: https://svnweb.freebsd.org/changeset/base/272805
>=20
> Log:
>  Use proper variable when looping through periphs with CAM_PERIPH_FREE.
>=20
>  PR:        194256
>  Submitted by:    Scott M. Ferris <smferris@gmail.com>
>  MFC after:    3 days
>  Sponsored by:    EMC/Isilon Storage Division
>=20

Reported by: Anton Rang <anton.rang AT Isilon DOT com>

> Modified:
>  head/sys/cam/cam_xpt.c
>=20
> Modified: head/sys/cam/cam_xpt.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D
> --- head/sys/cam/cam_xpt.c    Thu Oct  9 05:53:04 2014    (r272804)
> +++ head/sys/cam/cam_xpt.c    Thu Oct  9 05:53:58 2014    (r272805)
> @@ -2195,7 +2195,7 @@ xptperiphtraverse(struct cam_ed *device,
>        next_periph =3D SLIST_NEXT(periph, periph_links);
>        while (next_periph !=3D NULL &&
>            (next_periph->flags & CAM_PERIPH_FREE) !=3D 0)
> -            next_periph =3D SLIST_NEXT(periph, periph_links);
> +            next_periph =3D SLIST_NEXT(next_periph, periph_links);
>        if (next_periph)
>            next_periph->refcount++;
>        mtx_unlock(&bus->eb_mtx);
> @@ -2269,7 +2269,7 @@ xptpdperiphtraverse(struct periph_driver
>        next_periph =3D TAILQ_NEXT(periph, unit_links);
>        while (next_periph !=3D NULL &&
>            (next_periph->flags & CAM_PERIPH_FREE) !=3D 0)
> -            next_periph =3D TAILQ_NEXT(periph, unit_links);
> +            next_periph =3D TAILQ_NEXT(next_periph, unit_links);
>        if (next_periph)
>            next_periph->refcount++;
>        xpt_unlock_buses();
>=20



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3EB30773-FEC7-4DF9-95A1-E5963FB22112>