Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 16 Feb 2021 06:17:56 +1100
From:      Peter Jeremy <peter@rulingia.com>
To:        "Simon J. Gerraty" <sjg@freebsd.org>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: ee10666327b6 - main - Links for bmake and bmake.1
Message-ID:  <YCrI5Bfjh7Y5JfdW@server.rulingia.com>
In-Reply-To: <202102150122.11F1Mwq8070473@gitrepo.freebsd.org>
References:  <202102150122.11F1Mwq8070473@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--twrE+vEe3Pbt6a+X
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2021-Feb-15 01:22:58 +0000, "Simon J. Gerraty" <sjg@FreeBSD.org> wrote:
>The branch main has been updated by sjg:
>
>URL: https://cgit.FreeBSD.org/src/commit/?id=3Dee10666327b622c2f20a4ac17e7=
a5673b04e7c9a
>
>commit ee10666327b622c2f20a4ac17e7a5673b04e7c9a
>Author:     Simon J. Gerraty <sjg@FreeBSD.org>
>AuthorDate: 2021-02-15 01:20:10 +0000
>Commit:     Simon J. Gerraty <sjg@FreeBSD.org>
>CommitDate: 2021-02-15 01:22:21 +0000
>
>    Links for bmake and bmake.1
>   =20
>    Some folk forget that make is bmake, and want the links...

This breaks installworld with DESTDIR set:
=2E..
install  -o root  -g wheel -m 444  /usr/src/usr.bin/bmake/tests/variables/t=
0/expected.stdout.1 /mnt/usr/tests/usr.bin/bmake/variables/t0/expected.stdo=
ut.1
install  -o root  -g wheel -m 444  Kyuafile /mnt/usr/tests/usr.bin/bmake/va=
riables/t0/Kyuafile
install -l h -o root -g wheel -m 555  /mntmake /mntbmake
install: link /mntmake -> /mntbmake: No such file or directory
*** Error code 71

I suspect you want something like:
LINKS=3D ${BINDIR}/make ${BINDIR}/bmake

Also, it seems odd that you only want the link if tests are enabled -
this would seem likely to create more confusion, rather than less.

--=20
Peter Jeremy

--twrE+vEe3Pbt6a+X
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAmAqyMFfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF
QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi
CzTz+g/+LtEZ8vAieqw9FimgXwoYlqdl+PskdnGvOo3p02iJAz5NttAwpwRPlS36
Hy/RuJY1Ewhv3TxQUwGuynZuqNnCsCO86ICZdeI+YNPFKo5SMDIwiPxo9HRfZIOz
c99ZwfhFIutEVKycxG8cQNFCTG9N2ac+Mezn4/fU1yh6f4SH2CyUoxbYMgE/qvhe
skvD/vvL5wgWO5WGIp/d/qgdyrk7WtELxOxGJ/U9ZwR2BqY5RYJpN5CbcHqkHLvN
RiECPON0GeFIeEIxXiTzan5qrIRZeGNUE7zgfQHGxK5XmmvSdZlI5ZbbQKfEBTJd
PBJPDuyDJL+bi/VdVgCKV0sqYl5BD6myNOAonFiB45H2LAIdiANH9+XSpkvcZXil
aYDZwClPkc46w/06DVRreXrYru1y0ZNNNHhhO1i/k98G8bZO2EniFuxdMH7Rk072
prdg5wlH9WEmg2YTZeVEE4ePVBcPoJ1c5bU/YQe5OVVu2SzOiLrCddXDH2uBL/0b
E/LXt7RfLGThGo8BUkup7zviR9Iutckyo30kBOChH7HU3xuq5xgkUGLWF8jzAQMh
8ebhf0J4OGSQS0TmIdrF6UPp0eh6eP/NnfVOsgmOKYhsqHEYFrOO1qz5zffpBj12
BNwniQ+T6/vQgdLIpZ9LHZgmniGf+J+xLQcXTuoYVt/qMzaEOIo=
=ZcRd
-----END PGP SIGNATURE-----

--twrE+vEe3Pbt6a+X--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YCrI5Bfjh7Y5JfdW>