Date: Tue, 20 Jan 2009 12:52:33 +0100 From: Roman Divacky <rdivacky@FreeBSD.org> To: Konstantin Belousov <kib@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r187468 - head/sys/ufs/ffs Message-ID: <20090120115233.GA43828@freebsd.org> In-Reply-To: <200901201130.n0KBUM01043886@svn.freebsd.org> References: <200901201130.n0KBUM01043886@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 20, 2009 at 11:30:22AM +0000, Konstantin Belousov wrote: > Author: kib > Date: Tue Jan 20 11:30:22 2009 > New Revision: 187468 > URL: http://svn.freebsd.org/changeset/base/187468 > > Log: > When extending inode size, we call vnode_pager_setsize(), to have a > address space where to put vnode pages, and then call UFS_BALLOC(), > to actually allocate new block and map it. When UFS_BALLOC() returns > error, sometimes we forget to revert the vm object size increase, > allowing for the pages that are not backed by the logical disk blocks. > > Revert vnode_pager_setsize() back when UFS_BALLOC() failed, for > ffs_truncate() and ffs_write(). can you describe in what scenario this can trigger? can it be that many smallish (a few tens of kB?) of mmaped files being read/write may cause this? thnx
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090120115233.GA43828>