Date: Thu, 20 Nov 2003 11:29:16 -0500 (EST) From: John Baldwin <jhb@FreeBSD.org> To: Nate Lawson <nate@root.org> Cc: cvs-all@FreeBSD.org Subject: RE: cvs commit: src/sys/dev/acpica acpi.c acpi_cpu.c Message-ID: <XFMail.20031120112916.jhb@FreeBSD.org> In-Reply-To: <20031119160312.A69420@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20-Nov-2003 Nate Lawson wrote: > On Wed, 19 Nov 2003, John Baldwin wrote: >> One minor suggestion btw. Could you fix the hw.acpi.cpu.cpu_cx_lowest >> to use the "C1", "C2", and "C3" strings for its user-visible interface >> instead of the direct integer? Setting the value to C2 is a bit more >> intuitive than setting it to 1 to get C2. > > I considered this before, however Cx is really a type, not a given state. > There can be more than 3 sleep states. For instance, the IBM R40 has C1, > C2, C3, and C3 (4 states). An index was the only unique way I could > specify the states. The transition latency is also unique but setting a > state to 182 to get the last C3 state is even worse from a user > perspective. Ah. Maybe rename the sysctl/tunable to indicate that it is an index? -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20031120112916.jhb>