Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 27 Jan 2002 15:15:06 -0500 (EST)
From:      Andrew Gallatin <gallatin@cs.duke.edu>
To:        Bernd Walter <ticso@cicely8.cicely.de>
Cc:        freebsd-alpha@freebsd.org
Subject:   Re: ifconfig alignment fix
Message-ID:  <15444.24522.595616.15614@grasshopper.cs.duke.edu>
In-Reply-To: <20020126181352.C75106@cicely8.cicely.de>
References:  <20020126181352.C75106@cicely8.cicely.de>

next in thread | previous in thread | raw e-mail | index | archive | help

Nice fix.   I'm building a new kernel to test your patch now.

Any idea exactly what commit introduced this problem?

Drew


Bernd Walter writes:
 > 
 > The reason is that struct ifa_msghdr is not n * 8 bytes.
 > If an interface has an uneven number of addresses it toggles
 > alignment for the next interface.
 > I would be more happy when struct ifa_msghdr gets resized,
 > but that will break binary compatibility.
 > 
 > -- 
 > B.Walter              COSMO-Project         http://www.cosmo-project.de
 > ticso@cicely.de         Usergroup           info@cosmo-project.de
 > 
 > --- sys/net/rtsock.c.orig	Sat Jan 26 16:59:56 2002
 > +++ sys/net/rtsock.c	Sat Jan 26 17:00:01 2002
 > @@ -664,6 +664,7 @@
 >  		}
 >  		len += dlen;
 >  	}
 > +	len = _ALIGN(len);
 >  	if (cp == 0 && w != NULL && !second_time) {
 >  		register struct walkarg *rw = w;
 >  

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-alpha" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?15444.24522.595616.15614>