Skip site navigation (1)Skip section navigation (2)
Date:      Sat,  7 Dec 2013 17:54:07 +0100 (CET)
From:      Christoph Moench-Tegeder <cmt@burggraben.net>
To:        FreeBSD-gnats-submit@freebsd.org
Subject:   ports/184574: lang/ratfor : fix build with gcc47
Message-ID:  <20131207165407.CFE4831016@elch.exwg.net>
Resent-Message-ID: <201312071700.rB7H05b2030678@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         184574
>Category:       ports
>Synopsis:       lang/ratfor : fix build with gcc47
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Dec 07 17:00:05 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Christoph Moench-Tegeder
>Release:        FreeBSD 9.2-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD elch.exwg.net 9.2-RELEASE FreeBSD 9.2-RELEASE #11 r255911: Fri Sep 27 17:09:40 CEST 2013 cmt@elch.exwg.net:/usr/obj/usr/src/sys/ELCH amd64

lang/gcc47		gcc47-4.7.4.20131130
lang/ratfor		ratfor-1985.06_3

>Description:
Hi,

in an effort towards upgrading lang/gcc to gcc 4.7, I'm helping gerald@
in making ports gcc47-safe.
Please consider the following patch to your port. If you approve of the
patch, gerald@ has offered his help in commiting it.
If you're commiting yourself or have someone else commit this (or
another patch to the same effect), can you please add an additional
reference to ports/183342 in the commit message?
In my test environment, the port built successfully with lang/gcc47.

>How-To-Repeat:

>Fix:

A little cleaning up in ratfor's Makefile did the trick here. gcc
and make will do the right thing if (now), if you let them.

# make and the ports system will pick the right compiler and flags
# automatically, if one let's them do so. remove explicit rules from
# ratfor's Makefile.
$ svn status
M       Makefile
M       files/patch-Makefile

Index: Makefile
===================================================================
--- Makefile	(revision 334012)
+++ Makefile	(working copy)
@@ -26,7 +26,6 @@
 NO_STAGE=	yes
 post-patch:
 	@cd ${WRKSRC} ; ${PATCH} --quiet < testw.patch
-	@${REINPLACE_CMD} -e 's|%%F77%%|${F77}|' ${WRKSRC}/Makefile
 
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/ratfor77 ${PREFIX}/bin
Index: files/patch-Makefile
===================================================================
--- files/patch-Makefile	(revision 334012)
+++ files/patch-Makefile	(working copy)
@@ -1,16 +1,22 @@
---- Makefile~	Sat Jan 13 18:13:44 2007
-+++ Makefile	Sat Jan 13 18:14:35 2007
-@@ -28,11 +28,11 @@
+--- Makefile.orig	2013-11-16 17:28:28.000000000 +0100
++++ Makefile	2013-11-16 17:27:51.000000000 +0100
+@@ -26,13 +26,15 @@
+ clean:
+ 	rm -f *.o *~ ratfor ratfor77 a.out test testw test.f testw.f
  
- test: ratfor
+-test: ratfor
++test: test.f
++
++test.f: ratfor
  	./ratfor -o test.f test.r
 -	f77 -o test test.f
-+	%%F77%% -o test test.f
  
- testw: ratfor
+-testw: ratfor
++testw: testw.f
++
++testw.f: ratfor
  	./ratfor -o testw.f testw.r
 -	f77 -o testw testw.f
-+	%%F77%% -o testw testw.f
  
  tests: test testw
  	./test



Regards,
Christoph
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131207165407.CFE4831016>