Date: Sat, 20 Aug 2016 11:09:00 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Ryan Stone <rysto32@gmail.com> Cc: Slawa Olhovchenkov <slw@zxy.spb.ru>, Bruce Simpson <bms@fastmail.net>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Ryan Stone <rstone@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org> Subject: Re: svn commit: r304436 - in head: . sys/netinet Message-ID: <CAJ-Vmom8E%2BPm2dExD8oZCDe_Ax853JZ1YcbZkSLxcan_Ez8Qag@mail.gmail.com> In-Reply-To: <CAFMmRNx=2v=M8GCBQ_cN4pnuZ4VnyzncwAgsqMUE=ebz7pkp2A@mail.gmail.com> References: <201608182259.u7IMx5oW002018@repo.freebsd.org> <4fbc2e1d-3a62-5963-83d5-f9c931503e51@fastmail.net> <3806700d-ed27-7915-4818-c2d64f7b806d@fastmail.net> <CAFMmRNyi=PwE9pc9_8wCU63=HttUzFR4Zh2v=uHKcQ-zaLxdJQ@mail.gmail.com> <fcb33eac-ec99-03c7-57b5-f24f86c4f41a@fastmail.net> <CAFMmRNwDPy4Hd35DrfREZQzjvd89qw=zhEriddG8U8NV7tD=EA@mail.gmail.com> <6f4449f2-d145-8b49-c3f0-433e8ff4d2a2@fastmail.net> <CAFMmRNypgJc00XH277oB3EEGje4xq%2B8_qcJfZu4jjBfTfa7GGQ@mail.gmail.com> <20160820173050.GQ22212@zxy.spb.ru> <CAFMmRNx=2v=M8GCBQ_cN4pnuZ4VnyzncwAgsqMUE=ebz7pkp2A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20 August 2016 at 11:02, Ryan Stone <rysto32@gmail.com> wrote: > On Sat, Aug 20, 2016 at 1:30 PM, Slawa Olhovchenkov <slw@zxy.spb.ru> wrote: >> >> For host enought have [hidden] alias with broadcsts bits. >> Anyway, don't should relay on the L2 information, you can recive L3 >> unicast addressed packets (with alien dst IP address) in L2 broadcas >> packet. > > > This is still handled correctly. The new code only checks for L3 broadcast > addresses on L2 broadcast packets, but we still check the L3 address before > treating it as a broadcast. The problem is that I assumed that all paths > into the IP stack would set M_BCAST, but as Bruce has pointed out there are > cases like PPP which do not. Hi, So why not fix those paths? -adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmom8E%2BPm2dExD8oZCDe_Ax853JZ1YcbZkSLxcan_Ez8Qag>