Date: Sat, 16 Feb 2013 14:41:39 +0000 From: Chris Rees <utisoft@gmail.com> To: Emanuel Haupt <ehaupt@critical.ch> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Emanuel Haupt <ehaupt@freebsd.org>, ports-committers@freebsd.org Subject: Re: svn commit: r312354 - head/audio/xmp Message-ID: <CADLo839BjB8Uf7L9Gv0bK4XoUX2ediWjX1oAk0iw6i69L8J3Vg@mail.gmail.com> In-Reply-To: <20130216152406.04fe7cff5e79f9f2eb623140@critical.ch> References: <201302161421.r1GELYfr013815@svn.freebsd.org> <20130216152406.04fe7cff5e79f9f2eb623140@critical.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16 Feb 2013 14:24, "Emanuel Haupt" <ehaupt@critical.ch> wrote: > > Emanuel Haupt <ehaupt@FreeBSD.org> wrote: > > Author: ehaupt > > Date: Sat Feb 16 14:21:33 2013 > > New Revision: 312354 > > URL: http://svnweb.freebsd.org/changeset/ports/312354 > > > > Log: > > - Work around a case where .if !exists(${ETCDIR}/${f}) fails > > - Consistent usage of %%ETCDIR%% > > > > Modified: > > head/audio/xmp/Makefile > > head/audio/xmp/pkg-plist > > > > Modified: head/audio/xmp/Makefile > > ============================================================================== > > --- head/audio/xmp/Makefile Sat Feb 16 14:10:55 2013 > > (r312353) +++ head/audio/xmp/Makefile Sat Feb 16 14:21:33 > > 2013 (r312354) @@ -50,11 +50,9 @@ post-patch: > > @${REINPLACE_CMD} -e 's|\ install-conf||' > > ${WRKSRC}/Makefile.in > > post-install: > > - ${MKDIR} ${PREFIX}/etc/xmp > > + ${MKDIR} ${ETCDIR} > > .for f in ${CONFIG_FILES} > > > -.if !exists(${ETCDIR}/${f}) > > Can someone explain why this fails? I can't see from the patch, but I assume you forgot to include bsd.port.pre.mk. I would encourage the latter version anyway, since it preserves the lazy evaluation of ETCDIR, and doesn't cause a stat on every read of the Makefile. Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo839BjB8Uf7L9Gv0bK4XoUX2ediWjX1oAk0iw6i69L8J3Vg>