Date: Sun, 1 Oct 2017 23:35:14 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Ian Lepore <ian@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r324163 - in head: cddl/contrib/opensolaris/cmd/zfs cddl/contrib/opensolaris/cmd/zpool cddl/contrib/opensolaris/lib/libzfs/common cddl/contrib/opensolaris/lib/libzfs_core/common cddl/co... Message-ID: <61cbd210-a316-5f29-ce52-da40e4added5@FreeBSD.org> In-Reply-To: <1506877870.22078.28.camel@freebsd.org> References: <201710011611.v91GB8LM024101@repo.freebsd.org> <1506877870.22078.28.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/10/2017 20:11, Ian Lepore wrote: > On Sun, 2017-10-01 at 16:11 +0000, Andriy Gapon wrote: >> Author: avg >> Date: Sun Oct 1 16:11:07 2017 >> New Revision: 324163 >> URL: https://svnweb.freebsd.org/changeset/base/324163 >> >> Log: >> MFV r323530,r323533,r323534: 7431 ZFS Channel Programs, and >> followups >> > > Powerpc and sparc builds are dying on: > > src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c:870: > warning: comparison is always true due to limited range of data type > > "(unsigned char)anything >= 0" is also always true on clang, so I'm not > sure why it doesn't warn too. That's what I get for forgetting that other architectures use ZFS as well and, thus, not building universe. I've just committed a naive / trivial fix. Seems like there was just a single problem and not a systemic issue. Thank you for the report! -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?61cbd210-a316-5f29-ce52-da40e4added5>