Date: Thu, 15 Jan 2015 06:54:26 +0000 From: "Pokala, Ravi" <rpokala@panasas.com> To: "jhb@freebsd.org" <jhb@freebsd.org>, "eric@vangyzen.net" <eric@vangyzen.net>, "lars.engels@0x20.net" <lars.engels@0x20.net>, "allanjude@freebsd.org" <allanjude@freebsd.org> Cc: "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org> Subject: Re: [PATCH] Display progress during getmemsize() so the kernel doesn't look like it hanged Message-ID: <D0DCA0FF.129C55%rpokala@panasas.com>
next in thread | raw e-mail | index | archive | help
-----Original Message----- >Date: Tue, 13 Jan 2015 13:53:19 -0500 >From: John Baldwin <jhb@freebsd.org> >To: Eric van Gyzen <eric@vangyzen.net>, Lars Engels > <lars.engels@0x20.net>, Allan Jude <allanjude@freebsd.org> >Cc: freebsd-hackers@freebsd.org >Subject: Re: [PATCH] Display progress during getmemsize() so the > kernel doesn't look like it hanged >Message-ID: <3221643.2Qu3vC2WD5@ralph.baldwin.cx> >Content-Type: text/plain; charset=3D"us-ascii" > >On 1/13/15 10:48 AM, Eric van Gyzen wrote: >> On 01/13/2015 04:11, Lars Engels wrote: >>> On Mon, Jan 12, 2015 at 12:27:18AM -0500, Allan Jude wrote: >>>> Is this feature still useful with memtest.tests=3D0? >>> This feature is useful for everyone who has it set to 1, if they know >>> about it or not. So it's a very useful feature. >>=20 >> Agreed. >>=20 >> Comments on the patch: >>=20 >> The patch will divide by zero when PAGE_SIZE > 1 MiB. Maybe remove >> PAGES_PER_MB, and just use PAGES_PER_GB. Make it const, too. >>=20 >> The "total" line is mostly redundant with the later messages regarding >> "real memory" and "avail memory". I suggest removing it. > >I agree with these. One other nit is that FreeBSD tends to use all caps >for a macro rather than variables. Ravi, how about this variant, it >also only displays the dots if the memory test is enabled. Also, I >think the commit to disable the test should probably be merged to 10, yes. We have a winner. I regenerated the patch against 10-STABLE and attached it to the PR. Thanks all! -Ravi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D0DCA0FF.129C55%rpokala>