Date: Sat, 14 Sep 2002 23:18:01 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Nate Lawson <njl@FreeBSD.org> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: RE: cvs commit: src/sys/kern kern_exec.c Message-ID: <XFMail.20020914231801.jhb@FreeBSD.org> In-Reply-To: <200209141855.g8EItBC9035815@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14-Sep-2002 Nate Lawson wrote: > njl 2002/09/14 11:55:11 PDT > > Modified files: > sys/kern kern_exec.c > Log: > Move setugidsafety() call outside of process lock. This prevents a lock > recursion when closef() calls pfind() which also wants the proc lock. > This case only occurred when setugidsafety() needed to close unsafe files. > > Reviewed by: truckman Hmm, this is safe, but setugidsafety() has a race where it drops the filedesc lock around knote_fdclose(). Hmm, there actually is a race everywhere knote_fdclose() is called I think. I'll have to think about how to rework knote_fdclose(), knote_remove(), etc. to avoid the races. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020914231801.jhb>