Date: Fri, 12 Jun 2020 13:20:24 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 247204] sysutils/bastille has incorrect default configuration file handling Message-ID: <bug-247204-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D247204 Bug ID: 247204 Summary: sysutils/bastille has incorrect default configuration file handling Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: paul@gromit.dlib.vt.edu CC: christer.edwards@gmail.com Flags: maintainer-feedback?(christer.edwards@gmail.com) CC: christer.edwards@gmail.com The sysutils/bastille port uses @sample in pkg-plist to designate its defau= lt configuration file. However, it lists the "target_file" name, not the "sample_file" name. This causes any local modifications to /usr/local/etc/bastille/bastille.conf to be overwritten when the package is updated. A suggested fix is to change the config file pkg-plist entry to the followi= ng: @sample %%ETCDIR%%/bastille.conf.sample and to rename the distribution file in the port "bastille.conf.sample". Note, in Example 8.3 "Real Life Example, How @sample is Implemented" in the FreeBSD Porter's Handbook (https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/plist-k= eywords.html#plist-keywords-sample-example) it's clear that if only one filename is present in a @sample line then the = real target file is assumed to be that filename minus the ".sample" suffix: ''target_file=3D"${sample_file%.sample}"'' This is also stated in Section = 8.6.9 ("@sample file [file]"), though the language wording is not 100% clear. Section 8.3 ("Configuration Files") is clear in recommending the single-filename variant of @sample, using ".sample" as the suffix. The Bastille port should be changed to adhere with this recommendation. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-247204-7788>