Date: Sat, 17 Sep 2011 20:25:00 +0100 From: Chris Rees <utisoft@gmail.com> To: bf1783@gmail.com Cc: python@freebsd.org, bug-followup@freebsd.org Subject: Re: ports/115940: Missed one file in lang/python25 if NO_NIS defined Message-ID: <CADLo8386i5N_OzW5p0ZnMbh=51aJQZqkaDQ8a8kh3CCVeyWfcg@mail.gmail.com> In-Reply-To: <CAGFTUwOhU8jO6cVYzsKEGduoBiiFhCVP1cpp6G_0EEP7yxu3-w@mail.gmail.com> References: <CAGFTUwOhU8jO6cVYzsKEGduoBiiFhCVP1cpp6G_0EEP7yxu3-w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13 September 2011 09:05, b. f. <bf1783@googlemail.com> wrote:
>> This problem has been going on for a number of years, and as far as I
>> can see there isn't a proper and elegant solution.
>>
>> A fix is at [1], which should solve the problem, and I'm going to
>> tinderbox test and commit it if no-one complains.
>
> As Kozlov said earlier, that's a bit ugly. =A0I think it would be better
> to avoid attempting to build the module in the first place, by simply
> adding something like:
>
> .if !exists(/usr/bin/ypcat) # the world with NO_NIS
> =A0 =A0 =A0 =A0${REINPLACE_CMD} -e 's|rpcsvc/yp_prot.h|${NONEXISTENT}|' \
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0${PATCH_WRKSRC}/setup.py
> .endif
>
> to the pre-patch target, or something like:
>
> .if !exists(/usr/bin/ypcat) # the world with NO_NIS
> =A0 =A0 =A0 =A0${REINPLACE_CMD} -e '\|disabled_module_list =3D|s|]|, "nis=
"&|' \
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0${PATCH_WRKSRC}/setup.py
> .endif
Good point, and thanks for the idea, even if it did take me ten
minutes to work out how the hell your REINPLACE line worked ;) I've
simplified it a little.
Is it better now? It works in tinderbox so far....
http://www.bayofrum.net/~crees/patches/python-nis_failed-fix-bffix.diff
Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo8386i5N_OzW5p0ZnMbh=51aJQZqkaDQ8a8kh3CCVeyWfcg>