Date: Thu, 14 Aug 2014 09:39:13 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 192642] update mail/mailagent to a non-interactive, regular port Message-ID: <bug-192642-13-4PfDEPxDrr@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-192642-13@https.bugs.freebsd.org/bugzilla/> References: <bug-192642-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192642 --- Comment #15 from John Marino <marino@FreeBSD.org> --- (In reply to Yoshiaki Kasahara from comment #14) > I decided to move examples files in post-install. I hope using ${MV} > here is acceptable. Update pkg-plist accordingly. Also delete symlink > related lines from Makefile and pkg-plist. that's all fine. > Use pkg-deinstall to remove $orgname file instead of pkg-plist. I'm wondering if that's a good idea. There's a big push to reduce the number of files in ports, which is why you often see pkg-plist embedded in Makefile to save a single inode (which costs 4kb). If pkg-plist can handle a conditional delete and it saves a file, we should probably leave that how it was. > Define the filename for $orgname as a variable and use SUB_FILES to > generate pkg-{install,deinstall,message} (to make it easier to change). sounds good. > I checked the update port using poudriere testport with 9.3R and 10.0R. > If you need the entire output of that, I'll upload them later. no, I trust you. We always run the tests ourselves, but I like to have a good probably that it will pass the first time. > P.S. Poudriere is a great tool. I love it. :) I've made a few converts to poudriere due to my "demands" during triage. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-192642-13-4PfDEPxDrr>