Date: Sun, 13 Apr 2014 18:51:42 -0700 From: <dteske@FreeBSD.org> To: "'Jason Hellenthal'" <jhellenthal@dataix.net>, <dteske@FreeBSD.org> Cc: rc@FreeBSD.org, dteske@FreeBSD.org Subject: RE: network.subr _aliasN handling Message-ID: <008e01cf5784$174b63b0$45e22b10$@FreeBSD.org> In-Reply-To: <9013F8C6-E259-4FA2-800D-B5A43828F411@dataix.net> References: <04c901cf4c5d$a6a4a030$f3ede090$@FreeBSD.org> <0EBE3981-DC85-414D-85B8-7638F172040A@dataix.net> <04f701cf4c85$d1929680$74b7c380$@FreeBSD.org> <20140331.121757.1100840815853109946.hrs@allbsd.org> <069f01cf4d14$0ff03980$2fd0ac80$@FreeBSD.org> <0d7c01cf52b3$05a02a40$10e07ec0$@FreeBSD.org> <9013F8C6-E259-4FA2-800D-B5A43828F411@dataix.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Merged. stable/10: http://svnweb.freebsd.org/base?view=3Drevision <http://svnweb.fr= eebsd.org/base?view=3Drevision&revision=3D264438> &revision=3D264438 stable/9: http://svnweb.freebsd.org/base?view=3Drevision <http://svnweb.fre= ebsd.org/base?view=3Drevision&revision=3D264439> &revision=3D264439 --=20 Devin =20 From: Jason Hellenthal [mailto:jhellenthal@dataix.net]=20 Sent: Monday, April 7, 2014 4:08 PM To: <dteske@FreeBSD.org> Cc: <dteske@FreeBSD.org>; Hiroki Sato; <lists@jnielsen.net>; <rc@FreeBSD.or= g> Subject: Re: network.subr _aliasN handling =20 Looking forward to next week. Thanks again Devin. Nice work and well apprec= iated. --=20 Jason Hellenthal Voice: 95.30.17.6/616 JJH48-ARIN On Apr 7, 2014, at 18:45, <dteske@FreeBSD.org <mailto:dteske@FreeBSD.org> >= wrote: -----Original Message----- From: dteske@FreeBSD.org <mailto:dteske@FreeBSD.org> [mailto:dteske@FreeBS= D.org] Sent: Monday, March 31, 2014 12:05 PM To: 'Hiroki Sato'; dteske@FreeBSD.org <mailto:dteske@FreeBSD.org>=20 Cc: jhellenthal@dataix.net <mailto:jhellenthal@dataix.net> ; lists@jnielsen= .net <mailto:lists@jnielsen.net> ; rc@FreeBSD.org <mailto:rc@FreeBSD.org>=20 Subject: RE: network.subr _aliasN handling =20 -----Original Message----- From: Hiroki Sato [mailto:hrs@FreeBSD.org] Sent: Sunday, March 30, 2014 8:18 PM To: dteske@FreeBSD.org <mailto:dteske@FreeBSD.org>=20 Cc: jhellenthal@dataix.net <mailto:jhellenthal@dataix.net> ; lists@jnielsen= .net <mailto:lists@jnielsen.net> ; rc@FreeBSD.org <mailto:rc@FreeBSD.org>=20 Subject: Re: network.subr _aliasN handling =20 <dteske@FreeBSD.org <mailto:dteske@FreeBSD.org> > wrote in <04f701cf4c85$d1929680$74b7c380$@FreeBSD.org <mailto:04f701cf4c85$d1929= 680$74b7c380$@FreeBSD.org> >: =20 dt> But that wouldn't have deterred me. 30+ days of silence is dt> equivalent to acceptance -- just that I had noticed that the patch dt> could be expanded to include mdconfig{,2} scripts. Was going to dt> wait a full day to see if anyone balked at the expansion to dt> include mdconfig{,2} and then move forward. =20 I like the direction in general, but there are two more comments: =20 Committed change: http://svnweb.freebsd.org/changeset/base/264243 <https://urldefense.proofpo= int.com/v1/url?u=3Dhttp://svnweb.freebsd.org/changeset/base/264243&k=3D%2Fb= kpAUdJWZuiTILCq%2FFnQg%3D%3D%0A&r=3DMrjs6vR4%2Faj2Ns9%2FssHJjg%3D%3D%0A&m= =3DnCkVJD3sB71bLCO89KfhessydlHDLYlcBpM4mCc%2BXM8%3D%0A&s=3D60d03d403a4934bb= 721c6733fba18054f5ee240934ef932d24e103a864a6870b>=20 1. sort(1) cannot be used [snip] =20 Problem solved. Ended up beefing up the internal sort function (sort_lite()). Gave it some more options and regression tested it against several inputs and flags to always produce the same output as sort(1). 2. Please put the normalization part into a function and use it in get_if_var(), too. Adding another code for the same functionality makes maintenance difficult. Aforementioned enhancements to address that included in mentioned SVN r264243. --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you. _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?008e01cf5784$174b63b0$45e22b10$>