Date: Thu, 17 Oct 2019 17:51:28 +0200 From: Hans Petter Selasky <hps@selasky.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Gleb Smirnoff <glebius@FreeBSD.org> Subject: Re: svn commit: r353635 - in head/sys: netinet netinet6 Message-ID: <76f19c59-8ea5-b80a-a7b2-6f7df9030851@selasky.org> In-Reply-To: <20191017150822.GY4086@FreeBSD.org> References: <201910160911.x9G9BonH076337@repo.freebsd.org> <20191016165722.GU4086@FreeBSD.org> <138998a2-b304-fbe3-065d-e1df0a09af14@selasky.org> <20191017150822.GY4086@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2019-10-17 17:08, Gleb Smirnoff wrote: > On Wed, Oct 16, 2019 at 10:46:44PM +0200, Hans Petter Selasky wrote: > H> > as far as I remember I was against this changeset and I had > H> > several other developers agreed that this should be fixed in > H> > different way. Why did you proceed with checking it in? :( > H> > H> Hi Gleb, > H> > H> This issue has been discussed in-depth at various transport meetings and > H> we have agreed on a solution. > > Is the list of people who agreed longer than "Reviewed by" list? Yes. > > H> Are you seeing something broken as of this patch? > > As I already explained, first, we are dropping absolutely legitimate > packets. At the time of arrival there were nothing wrong about them. > This is idelogically wrong from viewpoint of abstract network stack. No packets are dropped. This was the initial version of my patch. Please re-read the history of the differential revision. > Second, the problem should be fixed in a different way: when we put > packets on the queue, we should take all important values out of the > ifnet and store them on queue entry. No, this won't work. Sometimes you need to send an ICMP error message back, but to which interface? You cannot use unit-numbers (risking the packet goes to wrong interface) nor pointers, which then can point to freed memory. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?76f19c59-8ea5-b80a-a7b2-6f7df9030851>