Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 23 Jul 1998 18:30:50 +0200 (CEST)
From:      Andre Albsmeier <andre.albsmeier@mchp.siemens.de>
To:        FreeBSD-gnats-submit@FreeBSD.ORG, jkh@FreeBSD.ORG
Subject:   bin/7381: rshd change breaks environment (fix included)
Message-ID:  <199807231630.SAA26689@internal>

next in thread | raw e-mail | index | archive | help

>Number:         7381
>Category:       bin
>Synopsis:       rshd change breaks environment (fix included)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 23 09:40:01 PDT 1998
>Last-Modified:
>Originator:     Andre Albsmeier
>Organization:
>Release:        FreeBSD 2.2.7-STABLE i386
>Environment:

FreeBSD 2.2.7 with rshd.c,v 1.9.2.8

>Description:

I use the environment variable REMOTEHOST in tcsh. When doing
a 'rsh host command' it was set properly on host. Since jkh's
"-Wall cleanup" this behaviour was broken.

>How-To-Repeat:

Use tcsh on server and client host and do a 

	rsh server 'echo $REMOTEHOST'

>Fix:

	Remove the 'int' before s = rresvport(&lport);

	
*** rshd.c.ORI	Thu Jul 23 18:08:48 1998
--- rshd.c	Thu Jul 23 18:22:09 1998
***************
*** 304,310 ****
  	(void) alarm(0);
  	if (port != 0) {
  		int lport = IPPORT_RESERVED - 1;
! 		int s = rresvport(&lport);
  		if (s < 0) {
  			syslog(LOG_ERR, "can't get stderr port: %m");
  			exit(1);
--- 304,310 ----
  	(void) alarm(0);
  	if (port != 0) {
  		int lport = IPPORT_RESERVED - 1;
! 		s = rresvport(&lport);
  		if (s < 0) {
  			syslog(LOG_ERR, "can't get stderr port: %m");
  			exit(1);
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199807231630.SAA26689>