Date: Thu, 22 Jan 2009 18:50:36 -0500 From: Jung-uk Kim <jkim@FreeBSD.org> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn: head/sys: compat/linprocfs i386/cpufreq Message-ID: <200901221850.37708.jkim@FreeBSD.org> In-Reply-To: <4978FC49.9080806@FreeBSD.org> References: <200901221706.n0MH6XN1017768@svn.freebsd.org> <200901221536.19137.jkim@FreeBSD.org> <4978FC49.9080806@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 22 January 2009 06:07 pm, Maxim Sobolev wrote: > Jung-uk Kim wrote: > > On Thursday 22 January 2009 03:24 pm, Maxim Sobolev wrote: > >> Jung-uk Kim wrote: > >>> Author: jkim > >>> Date: Thu Jan 22 17:06:33 2009 > >>> New Revision: 187594 > >>> URL: http://svn.freebsd.org/changeset/base/187594 > >>> > >>> Log: > >>> Replace couple of strcmp(cpu_vendor, "foo") with > >>> cpu_vendor_id for i386 > >> > >> What about amd64? > > > > It is #ifdef'ed out in linprocfs.c and smist.c is i386-specific, > > i.e., it does not compile on amd64. > > No, it's not. The function linprocfs_docpuinfo() are the same for > both amd64 and i386, so that you've just broken it for amd64 with > this commit. #ifdef was added with it: http://docs.freebsd.org/cgi/mid.cgi?200901221706.n0MH6XN1017768 Jung-uk Kim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200901221850.37708.jkim>