Date: Mon, 15 Aug 2016 20:20:15 +0200 From: Hans Petter Selasky <hps@selasky.org> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>, Gleb Smirnoff <glebius@FreeBSD.org> Cc: Sean Bruno <sbruno@FreeBSD.org>, Michael Zhilin <mizhka@gmail.com>, Garrett Cooper <ngie@FreeBSD.org>, sergey.dyatko@gmail.com, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r303848 - head/sys/netgraph Message-ID: <9055748a-51c1-c6d7-b22d-52abde4d01f7@selasky.org> In-Reply-To: <96EEC230-97EA-4686-9AFC-D5D6F98E70E8@gmail.com> References: <201608081931.u78JV1Ve026577@repo.freebsd.org> <20160812183845.GJ1076@FreeBSD.org> <96EEC230-97EA-4686-9AFC-D5D6F98E70E8@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 08/13/16 00:23, Ngie Cooper (yaneurabeya) wrote: > >> On Aug 12, 2016, at 11:38, Gleb Smirnoff <glebius@FreeBSD.org> wrote: >> >> Hi! >> >> Sorry, I'm afraid this isn't a correct fix. Simply adding checks >> against NULL to avoid panics at race conditions isn't a solution. >> >> I can provide help with this problem. It must be related to my >> callout changes, in case if this is a very recent problem. >> >> Is it a recent problem or an old one? > > I should have requested that the change be revised or further qualified first… as I said in the CR: > > “”” > In D7209#150056, @bz wrote: > Is this sudden problem possibly related to glebius' callout changes? I am not properly tracking things but if invariants changed and weren't reflected in the callers, that might explain. > I don't know to be honest. > > I'll add glebius (I should have done that in the first place). > “”” > Hi Ngie, Is this problem reproducable with projects/hps_head? --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9055748a-51c1-c6d7-b22d-52abde4d01f7>