Date: Sat, 27 Jul 2013 21:26:26 +0400 From: Andrej Zverev <az@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r323795 - in head: audio/mp32ogg audio/p5-Shout databases/p5-DBD-InterBase databases/p5-DBIx-Class-TimeStamp databases/p5-DBIx-MySQLSequence devel/cvslines devel/cvsplot devel/cvsstat d... Message-ID: <CAD5bB%2Bg6WqtM89M09G_JBnSN=8=EBsq06BBbi6wR5LB0JPCR6g@mail.gmail.com> In-Reply-To: <20130727172056.GA95369@FreeBSD.org> References: <201307271606.r6RG6PoL038173@svn.freebsd.org> <20130727162504.GA78281@FreeBSD.org> <CAD5bB%2BjewTn%2BB301gtkr1BVmSQsU%2BD7wy2We=bcd5ZsX=2y-cw@mail.gmail.com> <20130727172056.GA95369@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jul 27, 2013 at 9:20 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Sat, Jul 27, 2013 at 09:10:47PM +0400, Andrej Zverev wrote: >> On Sat, Jul 27, 2013 at 8:25 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote: >> > On Sat, Jul 27, 2013 at 04:06:25PM +0000, Andrej Zverev wrote: >> >> New Revision: 323795 >> >> URL: http://svnweb.freebsd.org/changeset/ports/323795 >> >> >> >> @@ -32,7 +29,7 @@ NO_BUILD= yes >> >> PLIST_FILES= bin/mp32ogg >> >> >> >> post-patch: >> >> - @${PERL} -pi -e "s,%%LOCALBASE%%,${LOCALBASE},g" ${WRKSRC}/mp32ogg >> >> + @${REINPLACE_CMD} -i '' -e 's|%%LOCALBASE%%|${LOCALBASE}|' [...] >> > >> > Andrej, can you clarify why explicit -i '' is needed here and quite a few >> > other ports in the commit? Is it because of otherwise .bak files will be >> > installed? Just looks weird to see these args all over the place... >> >> Yes, thats a reason. I don't see (personally) why REPLACE ARGS default >> with -i.bak, but overriding port Makefile everytime really annoying :( > > Understood, thanks for clarification. > > ./danfe > > P.S. Personally I like having those .bak files around, because it makes > debugging (via diff'ing) so much easier. Not related to the commit, but > just in case someone(tm) would have an idea to suppress them by default. > Please don't. Thank yo I agree, but I'm just changing tool (in this task). With the .bak by default I would have to do a full test to make sure there are no remaining leftovers. It would take a couple of weeks. Next time I'll try do my best as you suggested.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAD5bB%2Bg6WqtM89M09G_JBnSN=8=EBsq06BBbi6wR5LB0JPCR6g>