Date: Fri, 3 May 2019 10:57:12 +0200 From: Harry Schmalzbauer <freebsd@omnilan.de> To: Rick Macklem <rmacklem@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r346217 - in head/sys: fs/nfs fs/nfsclient kern sys Message-ID: <8a6cb225-8644-9949-09ab-7e1525e24034@omnilan.de> In-Reply-To: <201904150127.x3F1RG7X062973@repo.freebsd.org> References: <201904150127.x3F1RG7X062973@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 15.04.2019 um 03:27 schrieb Rick Macklem: > Author: rmacklem > Date: Mon Apr 15 01:27:15 2019 > New Revision: 346217 > URL: https://svnweb.freebsd.org/changeset/base/346217 > > Log: > Fix the NFSv4 client to safely find processes. > > r340744 broke the NFSv4 client, because it replaced pfind_locked() with a > call to pfind(), since pfind() acquires the sx lock for the pid hash and > the NFSv4 already holds a mutex when it does the call. > The patch fixes the problem by recreating a pfind_any_locked() and adding the > functions pidhash_slockall() and pidhash_sunlockall to acquire/release > all of the pid hash locks. > These functions are then used by the NFSv4 client instead of acquiring > the allproc_lock and calling pfind(). > > Reviewed by: kib, mjg > MFC after: 2 weeks Hello, I guess as long as r340744 isn't MFCd, this commit isn't needed in /stable/, is it? Any plans to MFC https://svnweb.freebsd.org/base?view=revision&revision=340744 (proc: convert pfind & friends to use pidhash locks and other cleanup) Thanks, -Harry
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8a6cb225-8644-9949-09ab-7e1525e24034>