Date: Fri, 3 May 2019 14:49:51 +0000 From: Rick Macklem <rmacklem@uoguelph.ca> To: Harry Schmalzbauer <freebsd@omnilan.de>, Rick Macklem <rmacklem@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r346217 - in head/sys: fs/nfs fs/nfsclient kern sys Message-ID: <YQBPR0101MB22603807DC874F381820ED02DD350@YQBPR0101MB2260.CANPRD01.PROD.OUTLOOK.COM> In-Reply-To: <8a6cb225-8644-9949-09ab-7e1525e24034@omnilan.de> References: <201904150127.x3F1RG7X062973@repo.freebsd.org>, <8a6cb225-8644-9949-09ab-7e1525e24034@omnilan.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Harry Schmalzbauer wrote: >Am 15.04.2019 um 03:27 schrieb Rick Macklem: >> Author: rmacklem >> Date: Mon Apr 15 01:27:15 2019 >> New Revision: 346217 >> URL: https://svnweb.freebsd.org/changeset/base/346217 >> >> Log: >> Fix the NFSv4 client to safely find processes. >> >> r340744 broke the NFSv4 client, because it replaced pfind_locked() wi= th a >> call to pfind(), since pfind() acquires the sx lock for the pid hash = and >> the NFSv4 already holds a mutex when it does the call. >> The patch fixes the problem by recreating a pfind_any_locked() and ad= ding the >> functions pidhash_slockall() and pidhash_sunlockall to acquire/releas= e >> all of the pid hash locks. >> These functions are then used by the NFSv4 client instead of acquirin= g >> the allproc_lock and calling pfind(). >> >> Reviewed by: kib, mjg >> MFC after: 2 weeks > >Hello, I guess as long as r340744 isn't MFCd, this commit isn't needed >in /stable/, is it? That is correct. I hadn't looked to see if r340744 was MFC'd when I did the= commit. >Any plans to MFC >https://svnweb.freebsd.org/base?view=3Drevision&revision=3D340744 >(proc: convert pfind & friends to use pidhash locks and other cleanup) No MFC is listed for the commit, so I am assuming that the author isn't pla= nning on MFC'ng it. rick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YQBPR0101MB22603807DC874F381820ED02DD350>