Date: Sat, 8 Nov 2014 12:00:00 -0500 From: Alexander Kabaev <kabaev@gmail.com> To: Mark Johnston <markj@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r274200 - head/share/mk Message-ID: <20141108120000.3f16feab@kan> In-Reply-To: <201411062246.sA6MkeLN018716@svn.freebsd.org> References: <201411062246.sA6MkeLN018716@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/GivU/EKY5jztYj/V4/o8gyA Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 6 Nov 2014 22:46:40 +0000 (UTC) Mark Johnston <markj@FreeBSD.org> wrote: > Author: markj > Date: Thu Nov 6 22:46:40 2014 > New Revision: 274200 > URL: https://svnweb.freebsd.org/changeset/base/274200 >=20 > Log: > Automatically build with debug symbols when building with WITH_CTF. > Otherwise there's nothing for ctfconvert to do, and it ends up > emitting an error for each object file. Also remove some redundant > checks from bsd.prog.mk and bsd.lib.mk. <SKIP> =20 > =20 > -.if ${MK_CTF} !=3D "no" && ${DEBUG_FLAGS:M-g} !=3D "" > +.if ${MK_CTF} !=3D "no" > CTFFLAGS+=3D -g > .endif > .else I have a question about this and another similar change. Does it have the effect of always leaving binaries with debug symbols in id WITH_CTF is in effect and do we now rely solely on install stripping binaries at later stage to get rid of the debug symbols? IMHO, we should only pass -g to ctfconvert if WITH_CTF is set _and_ user requested debug symbols explicitly. Your change seems to be breaking that. --=20 Alexander Kabaev --Sig_/GivU/EKY5jztYj/V4/o8gyA Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iD8DBQFUXkwWQ6z1jMm+XZYRAtWdAKCKP07oHjfePn5xbuesqZ9aNIvaXACcCIJw DPBG5lqNxib1TDfWHyXMQ+c= =PfF9 -----END PGP SIGNATURE----- --Sig_/GivU/EKY5jztYj/V4/o8gyA--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141108120000.3f16feab>