Date: Wed, 14 Oct 2009 11:45:48 +0200 From: Dimitry Andric <dimitry@andric.com> To: Doug Barton <dougb@FreeBSD.org> Cc: freebsd-rc@freebsd.org Subject: Re: A more thorough "Starting foo:" solution Message-ID: <4AD59DCC.9000008@andric.com> In-Reply-To: <4AD2460A.3000902@FreeBSD.org> References: <4AD2460A.3000902@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2009-10-11 22:54, Doug Barton wrote: > After giving this a more thorough look I realized that there were > quite a few places where $rc_quiet was being used directly in an rc.d > script (16 scripts total). > > I've already committed this to HEAD in order to try and make the MFC > deadline to potentially get it into 8.0, but I do want to give y'all a > chance to review this change as well. > > If anyone objects to this change being MFC'ed to 8.0-RELEASE, or has > other comments or suggestions please speak up ASAP. I see no problems with MFC'ing, this is a nice way of cleaning up. That said, there are still quite a number of scripts in rc.d that don't check rc_quiet at all, and just echo whatever they like. Therefore, couldn't all those "check_startmsgs && echo foo" constructs, plus the other echo's be replaced with, say, a spam() function from /etc/rc.subr? This function can then check in one central location for rc_startmsgs and decide whether to spam the console or not. One could even start implementing some verbosity level using this... :)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4AD59DCC.9000008>