Date: Sat, 25 Dec 1999 08:50:10 +0800 From: Peter Wemm <peter@netplex.com.au> To: Marcel Moolenaar <marcel@scc.nl> Cc: Bruce Evans <bde@zeta.org.au>, Dag-Erling Smorgrav <des@flood.ping.uio.no>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 Message-ID: <19991225005010.155641CC6@overcee.netplex.com.au> In-Reply-To: Message from Marcel Moolenaar <marcel@scc.nl> of "Fri, 24 Dec 1999 09:53:52 %2B0100." <386334A0.99AF5B87@scc.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
Marcel Moolenaar wrote: > Bruce Evans wrote: > > > > I couldn't disagree more. It is a matter of fact that strfile must be > > bootstrapped, even for certain old versions of FreeBSD that have it in > > /usr/games, because it is invoked by buildworld with a new flag (-C) > > which old versions of strfile don't have. > > Yes, but strfile shouldn't actually be in /usr/games IMO. It should be > in /usr/bin or be a special purpose build tool that never gets > installed. > > Adding the -C option was probably a mistake as well. It's sole purpose > is to support the FreeBSD tag, right? -C is silly. It adds a flag to the header of the generated files to say "this data *might* have a comment". fortune looks to see if there "might" be a comment and skips the double delimiters if so. The double delimiter is otherwise illegal. If an old fortune binary sees a new file, it won't know about the double delimiter. If a new fortune sees the double delimiter it will ignore it. This is exactly the same behavior that would happen if -C was unconditional. -C should be removed and the test for the double delimter should be unconditional. Cheers, -Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19991225005010.155641CC6>