Date: Sat, 27 Mar 2021 07:05:28 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Alexey Dokuchaev <danfe@freebsd.org>, Cy Schubert <cy@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r569288 - head/devel/bitkeeper Message-ID: <20210327060528.d62mjonjx6776lsq@aniel.nours.eu> In-Reply-To: <202103270441.12R4f6Qq059634@slippy.cwsent.com> References: <202103270245.12R2j5Ww059339@repo.freebsd.org> <20210327040518.GA30283@FreeBSD.org> <202103270441.12R4f6Qq059634@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--4foob2fxu5qn7xlx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 26, 2021 at 09:41:06PM -0700, Cy Schubert wrote: > In message <20210327040518.GA30283@FreeBSD.org>, Alexey Dokuchaev writes: > > On Sat, Mar 27, 2021 at 02:45:05AM +0000, Cy Schubert wrote: > > > New Revision: 569288 > > > URL: https://svnweb.freebsd.org/changeset/ports/569288 > > >=20 > > > Log: > > > devel/bitkeeper: pet portlint: compress man pages > > > =20 > > > Compress man pages satisfying portlint. > > > > Well, no, we compress manpages to satisfy common sense and save some > > disk space. :-) > > > > > ... > > > - ${MAKE_CMD} DESTDIR=3D${STAGEDIR}${PREFIX}/bitkeeper ${INSTALL_TARG= ET}) > > > + ${MAKE_CMD} DESTDIR=3D${STAGEDIR}${PREFIX}/bitkeeper ${INSTALL_TARG= ET});=20 > > \ > > > + ${GZIP_CMD} ${STAGEDIR}${PREFIX}/bitkeeper/man/man1/* > > > + > > >=20 > > > .include <bsd.port.mk> > > > > Why not amend MANDIRS to include custom manpage directory so that the > > standard `compress-man' from b.p.m could do its work? Also, you've > > inserted superfluous linefeed there. >=20 > I forgot about that, thanks. I used MANPREFIX instead. >=20 MANDIRS is the right thing to use, MANPREFIX is not support to be overwritt= en and only works by accident here. MANDIRS is the list of directories where we expect to lookup for manpages to compress them. Second if you do install manpages in unusual location, it is expected that = you add this location into manpath for the users to be able to actually access = those manpages. Somehow many ports seems to forget to do it. A good example of what to do h= ere is shown by the perl port which adds a perl5.conf to ETCDIR/man.d (so does = npm) Best regards, Bapt --4foob2fxu5qn7xlx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAmBeyyUACgkQY4mL3PG3 PlpUTQ/9FNYrHbknT36Zm01yw3e4WdT0DfuYbRHh8NnyiJy4y2l3L9ShazOR9ywG ofG3vTxAexl0x+QLctM0FssE7XZltt7dvGt914mxS/3lNceF3krXXJDo35JsM3jt K7W209zj355rU4GCKdFD7dvHCTpTKh/hEwor+xGRDeEfUIPe6rEIwpnERAuNvdSw WcOd5vN5iQHn+aD9AzYuHLnTFY0SqyVRt8xYqt4PAwOld1MJj3TfNBjbLbXM2CRS Rpobg6aizxjWWFHIx2RVe10xHXG4dOQHYfdTLOnNFu7LoUJ6G26gxemptpkCV5uP fNwZyAn1PXQjqztEtf/hXnHXCCCd51pqPD75htLyr3DBnYSxDGUzRgpoNBHbDF1R 1PkDHmXziZqlcwFqDnX9VngCETJUZf9IYAyrRipVtVHRgolHHHJL2C6zUaCyh382 TaRBqLy0Bi0A3yErgz8ja6p9AnTa1kDD5/jKQQoS8cdws1tPVZ/ecAycfkSpqQiX KgGAnkJeQmyhY4sJ+RZsW9AdBPICsD4wD6UOsyLEXlSJNw6bTcO8IJ88Pz+m44KI Xt30APuHDj1Q2gpBo5evcCzr+9mOZz2BTTvlb773dmw/YYNOOCbPKFbj7PLKHJ13 kUlhYgYAfnVvQ5lsLDz7jcJW2WhS4jigaUmOaJlGQ/PjN1WZAVI= =uKJM -----END PGP SIGNATURE----- --4foob2fxu5qn7xlx--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210327060528.d62mjonjx6776lsq>