Date: Fri, 22 Aug 2014 07:09:39 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: marino@freebsd.org, freebsd.contact@marino.st Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r365590 - in head/cad/spice: . files Message-ID: <20140822.070939.1253386656808735449.hrs@allbsd.org> In-Reply-To: <53F663B2.3000800@marino.st> References: <201408211941.s7LJf6de048334@svn.freebsd.org> <53F663B2.3000800@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Fri_Aug_22_07_09_39_2014_662)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit John Marino <freebsd.contact@marino.st> wrote in <53F663B2.3000800@marino.st>: fr> On 8/21/2014 21:41, Hiroki Sato wrote: fr> > Author: hrs fr> > Date: Thu Aug 21 19:41:06 2014 fr> > New Revision: 365590 fr> > URL: http://svnweb.freebsd.org/changeset/ports/365590 fr> > QAT: https://qat.redports.org/buildarchive/r365590/ ... fr> I'm sorry, but using freebsd-specific <bsd.prog.mk> in a ports vendor fr> makefile is NOT an improvement and frankly puts the build at risk on fr> DragonFly. fr> fr> I wish there was a rule that ports should not use system make fragments. fr> This is not a good practice. This port had a perfectly working and fr> generic makefile before. fr> fr> There's a good chance this just broke spice on DragonFly as the system fr> make file these are different. I can understand that vendor's Makefile should be platform-neutral, but I do not think there is advantage to maintain ${FILESDIR}/Makefile in a way not to use FreeBSD-specific stuff because it is used only by the port. Should we care about build on DragonFly? -- Hiroki ----Security_Multipart(Fri_Aug_22_07_09_39_2014_662)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlP2biMACgkQTyzT2CeTzy2h5gCgp+gfgDTkBNZPHH293lBZkonc L8oAoNvSHaLK11SA7Bxqg5QluMwoi2BD =2RHe -----END PGP SIGNATURE----- ----Security_Multipart(Fri_Aug_22_07_09_39_2014_662)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140822.070939.1253386656808735449.hrs>