Date: 13 May 2006 00:32:39 -0000 From: Coleman Kane <cokane@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/97178: lang/ruby18 improperly sets PKGNAMESUFFIX Message-ID: <20060513003239.54195.qmail@ramen.cokane.org> Resent-Message-ID: <200605121640.k4CGeD2X059249@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 97178
>Category: ports
>Synopsis: lang/ruby18 improperly sets PKGNAMESUFFIX
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri May 12 16:40:12 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: Coleman Kane <cokane@FreeBSD.org>
>Release: FreeBSD 7-CURRENT
>Organization:
FreeBSD developers
>Environment:
FreeBSD erwin 7.0-CURRENT FreeBSD 7.0-CURRENT #9: Sat Apr 29 20:02:50 EDT 2006 root@erwin:/usr/obj/usr/src/sys/ERWIN amd64
>Description:
When building lang/ruby18, there are two tunables:
WITH_PTHREADS and WITH_ONIGURUMA
When WITH_ONIGURUMA=yes and WITH_PTHREADS=no (or unset), the
PKGNAMESUFFIX is set to +oniguruma. When WITH_PTHREADS=yes, regardless of
the setting of WITH_ONIGURUMA, the PKGNAMESUFFIX is set to -pthreads.
Firstly, the PKGNAMESUFFIX for WITH_PTHREADS should be set to
"+pthreads". In addition, the support for oniguruma should not be hidden by
WITH_PTHREADS.
I think that the following naming is more reflective of the package's
tunables:
WITHOUT_PTHREADS && WITHOUT_ONIGURUMA --> ruby-1.8.x_y,z
WITH_PTHREADS && WITHOUT_ONIGURUMA -----> ruby+pthreads-1.8.x_y,z
WITHOUT_PTHREADS && WITH_ONIGURUMA -----> ruby+oniguruma-1.8.x_y,z
WITH_PTHREADS && WITH_ONIGURUMA --------> ruby+pthreads+oniguruma-1.8.x_y,z
>How-To-Repeat:
cd /usr/ports/lang/ruby18
make
<look at package name>
make clean
make WITH_ONIGURUMA=yes
<look at package name>
make clean
make WITH_ONIGURUMA=yes WITH_PTHREADS=yes
<look at package name>
make clean
make WITH_PTHREADS=yes
<look at package name>
make clean
>Fix:
Not 100% sure, but I think that where:
PKGNAMESUFFIX= +oniguruma
...
PKGNAMESUFFIX= -pthreads
it should be:
PKGNAMESUFFIX+= +oniguruma
...
PKGNAMESUFFIX+= +pthreads
I do not know if the decision to make the above is a maintainer mistake, or
a limitation in the ports/pkg system.
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060513003239.54195.qmail>