Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 Dec 2011 12:51:55 GMT
From:      Manolis Kiagias <manolis@FreeBSD.org>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/163178: [patch] databases/gnats4: edit-pr crashes trying to edit an existing PR
Message-ID:  <201112111251.pBBCptRH089966@red.freebsd.org>
Resent-Message-ID: <201112111300.pBBD03kc073611@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         163178
>Category:       ports
>Synopsis:       [patch] databases/gnats4: edit-pr crashes trying to edit an existing PR
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 11 13:00:02 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Manolis Kiagias
>Release:        9.0-RC3
>Organization:
>Environment:
FreeBSD joshua.freebsdgr.org 9.0-RC3 FreeBSD 9.0-RC3 #0: Sun Dec  4 08:01:02 UTC 2011     root@obrian.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
After installing and configuring the databases/gnats4 port, sumbitting a pr via email and trying to edit it with edit-pr, i.e. edit-pr 1:

/usr/local/bin/edit-pr: 1: Syntax error: Unterminated quoted string
/usr/local/bin/edit-pr: 172: Syntax error: Error in command substitution

>How-To-Repeat:
Follow the procedure above
>Fix:
Line 172 is missing a single quote. Apply the following patch

Patch attached with submission follows:

--- edit-pr.orig	2011-12-11 14:42:46.000000000 +0200
+++ edit-pr	2011-12-11 14:43:01.000000000 +0200
@@ -169,7 +169,7 @@
 	    type="`$QUERY_PR --field-type $field`"
 	    case $type in
 		[Ee][Nn][Uu][Mm])
-		    values=`$QUERY_PR --valid-values $field | tr '\n' ' ' | sed 's/ *$//g; s/ / | /g;s/^/[ /;s/$/ ]/;`
+		    values=`$QUERY_PR --valid-values $field | tr '\n' ' ' | sed 's/ *$//g; s/ / | /g;s/^/[ /;s/$/ ]/;'`
 		    valslen=`echo "$values" | wc -c`
 		    if [ "$valslen" -gt 160 ]
 		    then


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201112111251.pBBCptRH089966>